Render zero-radius round cuboids as cuboids in debug output - #976
Closed
fyrsta7 wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this draft because the underlying issue was fixed by dimforge/parry#437, which was merged after this PR was opened. The Rapier issue is now resolved, so this change is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #969 by rendering zero-radius round cuboids through the regular cuboid debug-render path.
Details
A
RoundCuboidwith a zero border radius is geometrically equivalent to its inner cuboid. The rounded-cuboid outline generation path can fail for that degenerate radius, so the debug renderer now handles this case directly for both 2D and 3D.Validation
git diff --checkcargo fmt --all --checkcargo test -p rapier3d --features debug-render debug_render_round_cuboid_with_zero_radiuscargo check -p rapier2d --features debug-render