Use brokered service for IManagedHotReloadService in VS#83018
Merged
tmat merged 2 commits intodotnet:mainfrom Apr 3, 2026
Merged
Use brokered service for IManagedHotReloadService in VS#83018tmat merged 2 commits intodotnet:mainfrom
tmat merged 2 commits intodotnet:mainfrom
Conversation
Member
Author
|
@DustinCampbell ptal |
tmat
commented
Apr 2, 2026
| @@ -1,42 +0,0 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
Member
Author
There was a problem hiding this comment.
Moved to EditorFeatures layer and linked to DevKit
tmat
commented
Apr 2, 2026
| { RemoteProjectInitializationStatusService.Moniker, new ServiceRegistration(ServiceAudience.Local, null, allowGuestClients: false) }, | ||
| { BrokeredServiceDescriptors.SolutionSnapshotProvider.Moniker, new ServiceRegistration(ServiceAudience.Local, null, allowGuestClients: false) }, | ||
| { BrokeredServiceDescriptors.DebuggerManagedHotReloadService.Moniker, new ServiceRegistration(ServiceAudience.Local, null, allowGuestClients: false) }, | ||
| { BrokeredServiceDescriptors.HotReloadSessionNotificationService.Moniker, new ServiceRegistration(ServiceAudience.Local, null, allowGuestClients: false) }, |
dibarbet
approved these changes
Apr 2, 2026
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Apr 15, 2026
Re-add HotReloadSessionNotificationService, ManagedHotReloadAgentManagerService, and GenericHotReloadAgentManagerService descriptors and registrations that were removed in PR dotnet#83018. These services are still used by the XAML diagnostics ServiceBrokerWrapper in VS, causing NotLocallyRegistered errors in DevKit logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Apr 15, 2026
Re-add HotReloadSessionNotificationService, ManagedHotReloadAgentManagerService, and GenericHotReloadAgentManagerService descriptors and registrations that were removed in PR dotnet#83018. These services are still used by the XAML diagnostics ServiceBrokerWrapper in VS, causing NotLocallyRegistered errors in DevKit logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dibarbet
added a commit
to dibarbet/roslyn
that referenced
this pull request
Apr 15, 2026
Re-add HotReloadSessionNotificationService, ManagedHotReloadAgentManagerService, and GenericHotReloadAgentManagerService descriptors and registrations that were removed in PR dotnet#83018. These services are still used by the XAML diagnostics ServiceBrokerWrapper in VS, causing NotLocallyRegistered errors in DevKit logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dibarbet
added a commit
that referenced
this pull request
Apr 15, 2026
Re-add HotReloadSessionNotificationService, ManagedHotReloadAgentManagerService, and GenericHotReloadAgentManagerService descriptors and registrations that were removed in [PR #83018](#83018). These services are still used by the XAML in the C# extension, and without them the logs are spammed with errors like ``` 2026-04-15 13:19:47.388 [debug] [serviceBroker/connect] [BrokeredServiceTraceListener] ServiceBroker Start: 0 : 2026-04-15 13:19:47.388 [debug] [serviceBroker/connect] [BrokeredServiceTraceListener] Requesting proxy to "Microsoft.VisualStudio.Debugger.HotReloadSessionNotificationService (0.1)" 2026-04-15 13:19:47.388 [debug] [serviceBroker/connect] [BrokeredServiceTraceListener] ServiceBroker Warning: 2 : 2026-04-15 13:19:47.389 [debug] [serviceBroker/connect] [BrokeredServiceTraceListener] Request for proxy to "Microsoft.VisualStudio.Debugger.HotReloadSessionNotificationService (0.1)" is declined: NotLocallyRegistered. 2026-04-15 13:19:47.389 [debug] [serviceBroker/connect] [BrokeredServiceTraceListener] ServiceBroker Stop: 0 : ``` See https://devdiv.visualstudio.com/DevDiv/_git/VS?path=%2Fsrc%2FXaml%2FDiagnostics%2FSource%2FCodeAnalysisDiagnostics%2FLanguageService%2FServiceBrokerWrapper.cs&_a=contents&version=GBmain ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/83184)
jaredpar
pushed a commit
to jaredpar/roslyn
that referenced
this pull request
Apr 16, 2026
Re-add HotReloadSessionNotificationService, ManagedHotReloadAgentManagerService, and GenericHotReloadAgentManagerService descriptors and registrations that were removed in PR dotnet#83018. These services are still used by the XAML diagnostics ServiceBrokerWrapper in VS, causing NotLocallyRegistered errors in DevKit logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow