Restore removed brokered service descriptors for hot reload#83184
Merged
dibarbet merged 1 commit intodotnet:mainfrom Apr 15, 2026
Merged
Restore removed brokered service descriptors for hot reload#83184dibarbet merged 1 commit intodotnet:mainfrom
dibarbet merged 1 commit intodotnet:mainfrom
Conversation
Re-add HotReloadSessionNotificationService, ManagedHotReloadAgentManagerService, and GenericHotReloadAgentManagerService descriptors and registrations that were removed in PR dotnet#83018. These services are still used by the XAML diagnostics ServiceBrokerWrapper in VS, causing NotLocallyRegistered errors in DevKit logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoeRobich
approved these changes
Apr 15, 2026
This was referenced Apr 16, 2026
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-add HotReloadSessionNotificationService, ManagedHotReloadAgentManagerService, and GenericHotReloadAgentManagerService descriptors and registrations that were removed in PR #83018. These services are still used by the XAML in the C# extension, and without them the logs are spammed with errors like
See https://devdiv.visualstudio.com/DevDiv/_git/VS?path=%2Fsrc%2FXaml%2FDiagnostics%2FSource%2FCodeAnalysisDiagnostics%2FLanguageService%2FServiceBrokerWrapper.cs&_a=contents&version=GBmain
Microsoft Reviewers: Open in CodeFlow