Use platform newline for C# elastic syntax facts#84407
Draft
mwiemer-microsoft wants to merge 1 commit into
Draft
Use platform newline for C# elastic syntax facts#84407mwiemer-microsoft wants to merge 1 commit into
mwiemer-microsoft wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
JoeRobich
reviewed
Jul 6, 2026
JoeRobich
left a comment
Member
There was a problem hiding this comment.
Should we update VB similarly.
|
|
||
| public SyntaxTrivia ElasticCarriageReturnLineFeed | ||
| => SyntaxFactory.ElasticCarriageReturnLineFeed; | ||
| => SyntaxFactory.ElasticEndOfLine(Environment.NewLine); |
Member
There was a problem hiding this comment.
I would prefer you rename this to ElasticNewLine or similar.
Contributor
|
This change is not correct and violates the documentation of ISyntaxFacts. Do not do this: The point if the property is to give you the elastic CRLF for VB or C#. It is not too give you an EOL. Let alone an ENV EOL. This also violates many Roslyn design envariants (like being isolated from the surrounding environment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #84347 as a small, reviewable slice.\n\nThis updates the C# syntax facts service so its default elastic end-of-line trivia uses the current platform newline instead of hard-coded CRLF. This is one of the lower-level pieces needed before broader code-action/refactoring line-ending preservation work.\n\nValidation:\n- dotnet test src\Workspaces\CSharpTest\Microsoft.CodeAnalysis.CSharp.Workspaces.UnitTests.csproj --filter FullyQualifiedName~CSharpSyntaxFactsServiceTests
Microsoft Reviewers: Open in CodeFlow