UIManager: Delete removeSubviewsFromContainerWithID#42066
Closed
RSNara wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
RSNara
force-pushed
the
export-D52345629
branch
2 times, most recently
from
233130d to
7f2159f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
RSNara
force-pushed
the
export-D52345629
branch
from
7f2159f to
1f6c078
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
RSNara
force-pushed
the
export-D52345629
branch
from
1f6c078 to
af4677a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
RSNara
force-pushed
the
export-D52345629
branch
from
af4677a to
7106826
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
Base commit: 9525074 |
RSNara
force-pushed
the
export-D52345629
branch
from
7106826 to
edfbed3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
RSNara
force-pushed
the
export-D52345629
branch
from
edfbed3 to
567ca99
Compare
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
…dren, manageChildren (facebook#42067) Summary: These methods should not be implemented in the new architecture. The **only** code that called these UIManagerModule methods was the paper renderer. And the New Architecture should instead use the Fabric renderer. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52345416
…erConfig() (facebook#41998) Summary: Now the error message propts people to turn on the interop layer. And, it adds more details to the suggestion to use hasViewManager(viewManagerName). Changelog: [Internal] Reviewed By: cortinico Differential Revision: D52002909
Summary: We should just delete this UIManagerModule api: - There are no usages of this api at Meta - The only usages found on GitHub are from old forks of React Native: [GitHub search](https://github.com/search?q=removeSubviewsFromContainerWithID+language%3AJavaScript&type=code&p=5) Changelog: [Android][Removed] - Delete UIManager.removeSubviewsFromContainerWithID Reviewed By: sammy-SC Differential Revision: D52345629
RSNara
force-pushed
the
export-D52345629
branch
from
567ca99 to
05eaf01
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…ok#42066) Summary: We should just delete this UIManagerModule api: - There are no usages of this api at Meta - The only usages found on GitHub are from old forks of React Native: [GitHub search](https://github.com/search?q=removeSubviewsFromContainerWithID+language%3AJavaScript&type=code&p=5) Changelog: [Android][Removed] - Delete UIManager.removeSubviewsFromContainerWithID Reviewed By: sammy-SC Differential Revision: D52345629
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…ok#42066) Summary: We should just delete this UIManagerModule api: - There are no usages of this api at Meta - The only usages found on GitHub are from old forks of React Native: [GitHub search](https://github.com/search?q=removeSubviewsFromContainerWithID+language%3AJavaScript&type=code&p=5) Changelog: [Android][Removed] - Delete UIManager.removeSubviewsFromContainerWithID Reviewed By: sammy-SC Differential Revision: D52345629
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52345629 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…ok#42066) Summary: We should just delete this UIManagerModule api: - There are no usages of this api at Meta - The only usages found on GitHub are from old forks of React Native: [GitHub search](https://github.com/search?q=removeSubviewsFromContainerWithID+language%3AJavaScript&type=code&p=5) Changelog: [Android][Removed] - Delete UIManager.removeSubviewsFromContainerWithID Reviewed By: sammy-SC Differential Revision: D52345629
Contributor
|
This pull request has been merged in f4e0061. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We should just delete this UIManagerModule api:
Changelog: [Android][Removed] - Delete UIManager.removeSubviewsFromContainerWithID
Reviewed By: sammy-SC
Differential Revision: D52345629