Merge ign-gazebo6 ➡️ gz-sim7 #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usly (gazebosim#1962) The main reason that the Resource Spawner took a long time to load is that it tried to fetch the list of all available models on Fuel instead of just the selected owner. And it did that while blocking the Qt thread, so the user was unable to interact with the GUI while the model list was being fetched. The approach I've taken is to only fetch the list of models for the default owner ("openrobotics") and allow users to add/remove any owner they want. The fetching is also done in a separate thread so as to not block the GUI. --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Include gz/msgs.hh instead of ignition * Install components.hh to gz/sim Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…ts on a topic (gazebosim#1994) * Working on marker topic Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fixed build Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fixed test Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Cleanup Signed-off-by: Nate Koenig <natekoenig@gmail.com> * codecheck Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Extending the feature for detachable_joint plugin to support re-attaching the joint again. By publishing to a topic, the child link can be easily reattached with a fixed joint to its parent link. Signed-off-by: Liam Han <liam@openrobotics.org> Signed-off-by: Liam Han <liamhan0905@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
…in a `<world>` (gazebosim#1998) Signed-off-by: Henrique-BO <henrique.barrosoliveira@usp.br>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
…azebosim#2006) Signed-off-by: Silvio Traversaro <silvio@traversaro.it> * TriggeredPublisher: don't catch FatalException It has been removed from recent versions of protobuf. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Merge ign-gazebo3 ➡️ ign-gazebo6
…azebosim#2006) Signed-off-by: Silvio Traversaro <silvio@traversaro.it> * TriggeredPublisher: don't catch FatalException It has been removed from recent versions of protobuf. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
…fore `Finalize` (gazebosim#2047) * Adds a warning if the `Server` method of a `TestFixture` is called before `Finalize This commit adds a warning if someone were to call `Server()` before `Finalize`. The rationale for this is because I made the mistake of not calling `Finalize` ina program I was writing. It took me some time to track down the root cause of the problem. I figure if we warn users it should be immediately obvious. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * switch to gzwarn over ignwarn Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * ignwarn cause citadel :( Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
gazebosim#2052) This fixes errors such as ``` Error [Utils.cc:174] Missing element description for [persistent] ``` Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…azebosim#2001) * Fix Joint Position Controller Behaviour Described in gazebosim#1997 There are several issues at play. First the target velcity calculation was wrong as described in gazebosim#1997. Secondly, even if we corrected that there was still incorrect behaviour. This is due to the fact that we use the PID's CmdMax to determine what the maximum velocity for the joint is. However, in the event a user does not set a `<cmd_max>` this defaults to zero and the joint does not move. Finally this PR updates the tests. Previously our tests were only testing the case where the position command was well above the position's maximum velocity, hence it would slide into position. This PR introduces a test where we snap the position of the joint into place instead. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Address PR feedback with regards to style. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Just one more thing Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * style Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * More minor style fixes Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * More minor style fixes Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Tracks periodic changes in scene broadcaster (gazebosim#2010) * Tracks periodic changes in scene broadcaster This commit proposes a change to the scene broadcaster which enables tracking of all components with periodic changes. This way if a component has a periodic change the scene broadcaster does not miss it. For more info see this discussion gazebosim#2001 (comment) where @azeey proposes this solution. This commit is WIP and I still need to handle entity/component removal and add tests. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Rework changes * Removes clone made of BaseComponent. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * More reworks of added APIs to ECM. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Fix tests Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Add ECM related tests. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Address spelling issue Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Arjo Chakravarty <arjo129@gmail.com> * Get rid of TODO Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Signed-off-by: Arjo Chakravarty <arjo129@gmail.com> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> * Migrate to new header. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Update test paths Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Update include/gz/sim/EntityComponentManager.hh Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Arjo Chakravarty <arjo129@gmail.com> * Rename methods Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * style Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Flipped data structure around Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Fix GCC warning Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Signed-off-by: Arjo Chakravarty <arjo129@gmail.com> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Merge ign-gazebo3 ➡️ ign-gazebo6
Merge ign-gazebo3 ➡️ ign-gazebo6
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
looks like the fuel-tools8 debbuilds failed so the new API needed by resource spawner is not available. |
|
|
@osrf-jenkins run tests please |
iche033
approved these changes
Aug 28, 2023
mjcarroll
approved these changes
Aug 28, 2023
azeey
commented
Aug 28, 2023
| @@ -111,6 +112,7 @@ set(tests_needing_display | |||
| shader_param_system.cc | |||
| thermal_sensor_system.cc | |||
| thermal_system.cc | |||
| triggered_camera.cc | |||
There was a problem hiding this comment.
@iche033 This was removed from gz-sim7 for some reason. I added it back here, but if you know it should be removed, let me know.
There was a problem hiding this comment.
probably got lost in the forward ports. The test was forward ported here but not the CMakeList.txt changes
|
ServerRepeat/ServerFixture.SdfWithoutWorld/0 is failing. Looking into it. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
It turns out the test is not relevant in gz-sim7 because SDF files without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gazebo6➡️gz-sim7Branch comparison: gz-sim7...ign-gazebo6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)