ref(issues): Remove useHasStreamlinedUI from GroupDetails and GroupEventDetails#110145
Closed
ref(issues): Remove useHasStreamlinedUI from GroupDetails and GroupEventDetails#110145
Conversation
Remove legacy UI code from groupDetails, groupActivity, groupEventDetails, and groupEventDetailsContent. This removes the old tab-based layout, GroupHeader, GroupSidebar, status banners, tab change tracking, old event error handling, and various conditional rendering branches for the legacy UI.
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Mar 6, 2026
| * TODO(streamline-ui): Remove this whole hook once the legacy UI is removed. The streamlined UI exposes the | ||
| * filters on the page so the user is expected to clear it themselves, and the empty state is actually expected. | ||
| */ | ||
| useEffect(() => { |
Member
There was a problem hiding this comment.
i imagine we had tests for this? that need to be cleaned up
Member
Author
There was a problem hiding this comment.
Looks like this wasn't tested 🤔
scttcper
approved these changes
Mar 6, 2026
scttcper
reviewed
Mar 6, 2026
Comment on lines
-209
to
-215
| {!hasStreamlinedUI && group.issueType === IssueType.MONITOR_CHECK_IN_FAILURE && ( | ||
| <CronTimelineSection | ||
| event={event} | ||
| organization={organization} | ||
| project={project} | ||
| /> | ||
| )} |
Member
There was a problem hiding this comment.
it does feel like maybe this was setup wrong cc @evanpurkhiser
Member
There was a problem hiding this comment.
or i guess something new exists? maybe i'm missing context https://github.com/getsentry/sentry/pull/89986/changes
Member
There was a problem hiding this comment.
yeah we have timelines in the new UIs afaik
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
The usePrompt hook was making an API call whose result was discarded - only isLoading was used, and feedback is now shown unconditionally.
Remove orphaned files that are no longer imported: - groupEventDetailsLoadingError.tsx - cronTimelineSection.tsx - groupEventHeader.tsx
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…lined-ui-core-views
scttcper
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One part of a many code deletions now that the old experience is dead.