-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(grouping): Tally frame types while building exception grouping components #81341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lobsterkatie
merged 11 commits into
master
from
kmclb-tally-frame-types-on-exception-grouping-components
Nov 27, 2024
Merged
feat(grouping): Tally frame types while building exception grouping components #81341
lobsterkatie
merged 11 commits into
master
from
kmclb-tally-frame-types-on-exception-grouping-components
Nov 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81341 +/- ##
=======================================
Coverage 80.35% 80.35%
=======================================
Files 7219 7219
Lines 319608 319635 +27
Branches 20770 20770
=======================================
+ Hits 256819 256846 +27
Misses 62395 62395
Partials 394 394 |
319dddb to
bc453dc
Compare
armenzg
approved these changes
Nov 27, 2024
jan-auer
added a commit
that referenced
this pull request
Nov 28, 2024
* master: (219 commits) fix: flatten searchable os distribution fields (#81297) chore(profiling): Remvoe unused profile functions metrics hook (#81396) fix(prompts): Properly return false instead of undefined when prompt data is null (#81404) fix(insights): broken screen rendering doc link (#81257) fix(rpc): Only groupby when needed (#81403) feat(grouping): Tally frame types while building exception grouping components (#81341) fix(similarity): Limit > 30 system frame check to Java (#81385) feat(alerts): Adds EAP spans results consumer configs (#81365) ref(insights): simplify domain view header by using tab links (#81324) fix(issues): Add projectId for flag onboarding on click (#81387) chore(flamegraphs): Remove unused legacy flamegraph code path (#81381) fix(performance): No table overflow + glitchy behaviour (#81378) feat(widget-builder): Add feature flag for redesign (#81377) feat(profiling): Clean up continuous profiling ui and compat flags (#81260) feat(visibility): Clamp date range for `TagStore` queries (#81363) test(taskbroker): Add CLI command for sending taskbroker tasks (#81319) feat(dashboards): Add ff for favouriting dashboards (#81368) fix(trace) match event_id by error (#81370) fix(insights): add missing slash on performance moving banner (#81364) ref(models): Include event id in `Event` repr (#81345) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
…omponents (#81341) This adds a tally of the four possible types of frames (in-app vs system, each of which can be contributing or not) to exception and chained exception grouping components created by the newstyle config. To make this work: - First, each `FrameGroupingComponent` stores on itself whether it's in-app or not.* - Then, as we're walking through the frames when building the `StacktraceGroupingComponent`, we note each frame component's `in_app` and `contributing` values, and keep a running tally of the different frame types, which we then store on the stacktrace component. - Next, when creating an `ExceptionGroupingComponent`, we read the frame tally from the stacktrace component and store it on the exception component. - Finally, if we have a chained exception, we add up the tallies from the individual exception components and store a combined tally on the `ChainedExceptionGroupingComponent`. Having this data will enable us to do a few different things (in follow-up PRs, if and when we choose to): - Gather metrics on the precise mix of frames. Right now we have a separately-calculated `in_app_frame_mix` metric, which just records the presence, or lack thereof, of in-app and system frames in the initial event in a group; should we choose, this will allow us to gather more detailed metrics. (One place this might be useful is as we start automatically adding code-mappings-based stacktrace rules to projects, to see the change in percentage of in-app vs system frame.) We also could consider switching the frame mix metric to rely on these counts, as it would make the code quite a bit simpler. - Store this information in grouphash metadata. - Use the information when deciding whether to send events to Seer. *Note: Though in general this PR only applies to newstyle grouping, I did add in-app tracking to legacy frame components, too, to make them compatible with the newly-modified `assemble_stacktrace_component` helper both configs use.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tally of the four possible types of frames (in-app vs system, each of which can be contributing or not) to exception and chained exception grouping components created by the newstyle config. To make this work:
FrameGroupingComponentstores on itself whether it's in-app or not.*StacktraceGroupingComponent, we note each frame component'sin_appandcontributingvalues, and keep a running tally of the different frame types, which we then store on the stacktrace component.ExceptionGroupingComponent, we read the frame tally from the stacktrace component and store it on the exception component.ChainedExceptionGroupingComponent.Having this data will enable us to do a few different things (in follow-up PRs, if and when we choose to):
in_app_frame_mixmetric, which just records the presence, or lack thereof, of in-app and system frames in the initial event in a group; should we choose, this will allow us to gather more detailed metrics. (One place this might be useful is as we start automatically adding code-mappings-based stacktrace rules to projects, to see the change in percentage of in-app vs system frame.) We also could consider switching the frame mix metric to rely on these counts, as it would make the code quite a bit simpler.*Note: Though in general this PR only applies to newstyle grouping, I did add in-app tracking to legacy frame components, too, to make them compatible with the newly-modified
assemble_stacktrace_componenthelper both configs use.