Skip to content

Conversation

timothyqiu
Copy link
Member

symbol_type is the text that appears at the top of the EditorHelpBit tooltip.

image

Using TextFile is confusing for translators since TextFile is usually used as an untranslatable class name in other places.

CamelCase naming is also inconsistent with other symbol types.

godot/editor/editor_help.cpp

Lines 4090 to 4092 in 134da37

} else if (item_type == "local_constant" || item_type == "local_variable") {
symbol_type = (item_type == "local_constant") ? TTR("Local Constant") : TTR("Local Variable");
symbol_hint = SYMBOL_HINT_ASSIGNABLE;

@timothyqiu timothyqiu added enhancement topic:editor cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Mar 6, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Mar 6, 2025
@akien-mga
Copy link
Member

Seems fine, though I wonder whether the "Text" part is really useful here or if it should just be "File", avoiding the need to query editor settings just for this.

@akien-mga akien-mga removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label May 13, 2025
@Repiteo Repiteo merged commit 30a0e46 into godotengine:master May 13, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented May 13, 2025

Thanks!

@timothyqiu timothyqiu deleted the text-file branch May 13, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants