Change type of size_2d_override to Vector2 #104602
Open
+74
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This was already rejected in: Where a different solution was decided on, so this isn't likely to be accepted Adding compatibility binds for the setter/getter doesn't solve compatibility completely here, for example with C# which doesn't use them |
timoschwarzer
force-pushed
the
fix/subviewport-size-2d-override-float
branch
2 times, most recently
from
6108920 to
8c3a5b1
Compare
# Conflicts: # misc/extension_api_validation/4.4-stable.expected
timoschwarzer
force-pushed
the
fix/subviewport-size-2d-override-float
branch
from
8c3a5b1 to
0ecb198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104601
Added compatibility methods that mimic the previous behavior.