Add support for custom RandomNumberGenerator in functions pick_random and pop_random in Array #116271
Draft
Scarface1809 wants to merge 1 commit intogodotengine:masterfrom
Draft
Add support for custom RandomNumberGenerator in functions pick_random and pop_random in Array #116271Scarface1809 wants to merge 1 commit intogodotengine:masterfrom
RandomNumberGenerator in functions pick_random and pop_random in Array #116271Scarface1809 wants to merge 1 commit intogodotengine:masterfrom
Conversation
Scarface1809
force-pushed
the
array_pick_random
branch
6 times, most recently
from
7754b45 to
df5a9b0
Compare
Scarface1809
force-pushed
the
array_pick_random
branch
3 times, most recently
from
eb666b9 to
3cfbce2
Compare
Scarface1809
force-pushed
the
array_pick_random
branch
5 times, most recently
from
30a9dd9 to
c268d11
Compare
Scarface1809
force-pushed
the
array_pick_random
branch
from
c268d11 to
e1689ac
Compare
|
Fun to see that you took it upon yourself to implement my proposal! :) Or maybe it does break it at some lower level...? |
Contributor
Author
Trying to at least. It has more issues than i expected. |
Member
|
It adds a new unconditional parameter to a method, that breaks compatibility |
Oh, I thought it was conditional in both cases, going with the original behavior if no RNG is provided... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
pick_randomandpop_randomfunctions inArraysupporting a customRandomNumberGenerator, as mentioned in Godot Proposal Issue #14115.