Add warnings in Node3D about losing transformations#116759
Open
Lakamfo wants to merge 5 commits intogodotengine:masterfrom
Open
Add warnings in Node3D about losing transformations#116759Lakamfo wants to merge 5 commits intogodotengine:masterfrom
Lakamfo wants to merge 5 commits intogodotengine:masterfrom
Conversation
Introduce get_configuration_warnings() in Node3D to warn when a Node3D is parented to a node without a 3D transform (and not the scene root) while having an owner. Adds the method declaration to the header and includes scene/main/window.h in the implementation. The warning helps users detect that the node will not inherit a 3D transform
Member
|
There are some odd changes in this, did you write this code yourself or did you use AI to write it? Please see our AI policy |
Author
I used AI for reference only. Code was written by me, with some partial copy-paste from path_2d.cpp |
Removed an unused viewport include since it is part of "scene/main/window.h" and adjusted the formatting. Simplified the get_owner() null check to a boolean check and rewrote the configuration warning as a single string containing a '\n'
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add warnings in Node3D to warn when a Node3D is parented to a node without a 3D transform (and not the scene root) and has an owner. The warning helps users detect that the node will not inherit a 3D transform.
Example
Closes: godotengine/godot-proposals#14328