sdl: Update to 3.4.4#119024
Conversation
| if (controller.vendorName) { | ||
| name = controller.vendorName.UTF8String; | ||
| } else { | ||
| if (controller.vendorName) { | ||
| name = controller.vendorName.UTF8String; | ||
| if (@available(macOS 10.15, iOS 13.0, tvOS 13.0, *)) { | ||
| if (controller.productCategory) { | ||
| name = controller.productCategory.UTF8String; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
CC @sorascode
See also libsdl-org/SDL@ef0ae4c and libsdl-org/SDL@fa3467a
Do you think this change will introduce regressions for issues like #98008 and #96756 or any other regressions?
There was a problem hiding this comment.
@AdriaandeJongh Hello, may I ask if you can test this PR for any regressions for your issue, please?
There was a problem hiding this comment.
With this PR on macOS 26.4.1, using:
func _input(event: InputEvent) -> void:
if event is InputEventJoypadButton:
var iejb: InputEventJoypadButton = event
print(Input.get_joy_info(iejb.device))
print(Input.get_joy_name(iejb.device))
Microsoft Xbox One Wireless Controller:
{ "raw_name": "Controller", "vendor_id": "1118", "product_id": "736" }
Controller
Sony Playstation 4 Wireless Controller:
{ "raw_name": "PS4 Controller", "vendor_id": "1356", "product_id": "1476"}
PS4 Controller
8BitDo Pro Controller:
{ "raw_name": "8BitDo Pro 3", "vendor_id": "1452", "product_id": "4" }
8BitDo Pro 3
So it looks like the Xbox controller returns a generic name with this change and that could be considered a regression. However, with the vendor_id and product_id, is it possible to deduce that this is an Xbox controller anyway?
There was a problem hiding this comment.
Thank you for testing! I would consider this a regression, I will propose a solution to SDL later when I can!
I'm not sure about deleting: 0005-fix-libudev-dbus.patch 0008-fix-linux-joycon-serial-num.patch
3 participants
Tested with Xbox 360, works on Linux and Wine.