Skip to content

NodePath export hint#39155

Draft
brndel wants to merge 2 commits intogodotengine:3.xfrom
brndel:nodepath-export-hint
Draft

NodePath export hint#39155
brndel wants to merge 2 commits intogodotengine:3.xfrom
brndel:nodepath-export-hint

Conversation

@brndel
Copy link
Copy Markdown

@brndel brndel commented May 29, 2020

export(NodePath, Button) var my_node_path
Makes only Button (and its subclasses) selectable in the 'Select a Node' dialog window in the editor
image

this also works for global classes

#Inventory.gd
extends Node
class_name Inventory

#...
#Player.gd
#...

export(NodePath, Inventory) var inventory_path

#...

image

@brndel brndel requested review from bojidar-bg and vnen as code owners May 29, 2020 22:08
@Calinou Calinou added this to the 3.2 milestone May 29, 2020
@brndel brndel requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@aaronfranke aaronfranke modified the milestones: 3.2, 3.3 Mar 16, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@Chaosus Chaosus modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
@aaronfranke aaronfranke modified the milestones: 3.5, 3.x Jun 18, 2022
@mphe
Copy link
Copy Markdown
Contributor

mphe commented Jun 24, 2022

I've been using this patch for ages now and it works perfectly.
Is there any reason why this is not getting merged?

@akien-mga akien-mga removed the request for review from bojidar-bg June 24, 2022 11:46
@akien-mga
Copy link
Copy Markdown
Member

It needs review from @vnen or other contributors familiar with the GDScript 3.x implementation.

As there's a lot of backlog and work on 4.0, it's difficult to give priority to all PRs for review. But you commenting that you've been using this in production is definitely valuable, tests help a lot with getting a qualified review to merge a new feature.

@fire
Copy link
Copy Markdown
Member

fire commented Nov 5, 2024

I added the tag to be salvageable because people use this in their games. Hopefully, someone can be a hero and update this to Godot Engine 4.

@aaronfranke aaronfranke marked this pull request as draft April 10, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants