[3.x] Add a get_as_bulk_array method to multimesh#47282
[3.x] Add a get_as_bulk_array method to multimesh#47282puchik wants to merge 1 commit intogodotengine:3.xfrom
Conversation
There was a problem hiding this comment.
Typo, You've accidently changed this to be the same as get_as_bulk_aray
There was a problem hiding this comment.
The description needs to be updated to be very clear that this will cause stalls in multithreaded environments. Also, the first line is not really applicable anymore. The use case for set_as_bulk_array is very different
There was a problem hiding this comment.
I removed the second sentence and replaced it with "Note that this will cause stalls in multithreaded environments". So the whole first line is Gets all data related to the instances in one go. Note that this will cause stalls in multithreaded environments. and the rest is the same. Does that work?
Both VisualServer.xml and MultiMesh.xml have that same text.
23d8f1f to
d42f946
Compare
d42f946 to
4c82ce8
Compare
71cb8d3 to
c58391c
Compare
Added a
get_as_bulk_arraymethod to multimesh.Neither
getnorsetof bulk arrays for multimeshes exists in 4.0/master right now so I don't think it can be implemented for those and cherry picked down.Closes #47158