Skip to content

[3.x] Add a get_as_bulk_array method to multimesh#47282

Open
puchik wants to merge 1 commit intogodotengine:3.xfrom
puchik:multimesh-bulk-array-3.x
Open

[3.x] Add a get_as_bulk_array method to multimesh#47282
puchik wants to merge 1 commit intogodotengine:3.xfrom
puchik:multimesh-bulk-array-3.x

Conversation

@puchik
Copy link
Copy Markdown
Contributor

@puchik puchik commented Mar 23, 2021

Added a get_as_bulk_array method to multimesh.

Neither get nor set of bulk arrays for multimeshes exists in 4.0/master right now so I don't think it can be implemented for those and cherry picked down.

Closes #47158

@puchik puchik requested review from a team as code owners March 23, 2021 02:39
Comment thread doc/classes/VisualServer.xml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, You've accidently changed this to be the same as get_as_bulk_aray

Comment thread doc/classes/MultiMesh.xml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description needs to be updated to be very clear that this will cause stalls in multithreaded environments. Also, the first line is not really applicable anymore. The use case for set_as_bulk_array is very different

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the second sentence and replaced it with "Note that this will cause stalls in multithreaded environments". So the whole first line is Gets all data related to the instances in one go. Note that this will cause stalls in multithreaded environments. and the rest is the same. Does that work?

Both VisualServer.xml and MultiMesh.xml have that same text.

@puchik puchik force-pushed the multimesh-bulk-array-3.x branch from 23d8f1f to d42f946 Compare March 24, 2021 01:16
Comment thread doc/classes/VisualServer.xml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants