-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Export] Add one-click deploy over SSH for the desktop exports. #63312
Conversation
I suppose this also addresses godotengine/godot-proposals#1072 to an extent.
Feel free to use platform-icons.zip (which I've made over 1 year ago, but never got to work within Godot itself). |
Changed platform icons to this set, and run icons to the gray version of them (+ added UWP icon), also using SVG icons fixes icon scaling in the hiDPI mode.
|
6ee7595
to
ea5678d
Compare
With the full set of remote debug options enabled, toolbar become quite cluttered, so I guess some sort of UI redesign might be necessary. And running projects using local export templates might be desired, as well (you can use this PR for this by connecting to the localhost, but it's definitely not a proper solution). |
I've already commented in godotengine/godot-proposals#2124, but I would rather use macOS Finder icon for macOS. The Apple logo is too generic, and it could be confused for iOS at a glance. |
Works great on Steam Deck! Stepping through the script code in debug sessions is working fine too.
Could adjust some things too, but would be good to know the state first |
Oh, I completely forgot to mark is as ready after adding script templates to the export options. Rebased, and will re-test it to make sure everything is still working tomorrow.
It's the same for Android and Web, so probably no.
No, it's not supported. Should be easy to add, but since it's uploading the project as a single zip, it probably won't do much. |
Add one-click deploy over SSH for the desktop exports. Add ZIP export option for Linux and Windows. Change export plugin icons to SVG format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I'll merge after beta 12 (releasing tomorrow) so we have a few days to test before the next beta.
Changes not needed, misunderstanding.
Thanks! |
Is there any documentation on how to get this working? I work on a linux machine and would like to one click deploy to a windows device. I tried the latest one click deploy page, but it seems to be the same one as the 3.x stable version https://docs.godotengine.org/en/latest/tutorials/export/one-click_deploy.html |
All this does for me on the Steam Deck is creating an empty directory in /tmp:
This really needs some documentation. |
Works for me on SteamDeck, was following the docs by @akien-mga and @bruvzg above, what were your steps to set the connection up? |
@BAndiT1983
When I check on the deck, there is indeed a new tmp folder in /tmp, but it's empty. Thanks! EDIT: I did some more digging around and changing the scp path to something nonsensical in the editor settings doesn't throw an error, while changing the ssh path does. This leads me to believe that the SCP commands aren't even called after the temporary folder is created. EDIT 2: I tried running with the --verbose flag, and here's the output:
|
Will cross-check when i get to my Deck, but overall it looks correct at first glance |
I'm still getting the same issue as detailed in #63312 (comment) |
Sorry for long absence (work and other stuff came in-between), have finally checked under Windows and the export (in Godot 4.02) is also not starting automatically on Deck, tried to run the exported app from the /tmp/tmp..., but it fails, at least the files are transferred. Will analyse why it SIGSEGVs there. Does it run on your Deck? Edit: Export from Linux didn't start either, but at least the exported app is starting, needs also some investigation on the reasons, as it's the same project just transferred from different OSes. Edit 2: Executed Godot editor under Linux with --verbose argument and got following log while deploying to the Deck, something changed (on whichever side) in the meantime it seems, as this process worked just fine in February.
Edit 3: As quick workaround you can also use |
Same workaround from |
@BAndiT1983
With --verbose:
Nothing happens on the deck. EDIT 1: I've checked the tmp directories on the deck, and they're all empty. |
Update: I was trying it on Godot 4.0.0, after updating to Godot 4.0.2 it works perfectly! |
If it stalls with |
Adds one-click deploy and remote debug option for desktop targets, similar to the same feature for Android and Web.
remote_debug.mov
TODO:
mktemp
and unzip should be replaced with PowerShell equivalents). The built-in version of OpenSSH is running as a service and cannot access a desktop session, therefor task scheduler is used to start / terminate the uploaded project.scp
andssh
.Related proposals godotengine/godot-proposals#4897, godotengine/godot-proposals#2608, not exactly the same but should simplify testing on the portables like Steam Deck, or multiple platforms in general.
Required tools / config to use this:
kill
,mktemp
,rm
,unzip
commands/utilities available and in path.DISPLAY=:0
;