Add set_value_no_signal() to Range
#68097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Nov 4, 2022
|
Thanks! |
|
This change is essential for a 3.x project I'm working on; should I open a PR with this backported to 3.x, considering the breaking changes? |
|
This PR does not break compatibility so it can be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to
set_pressed_no_signal()in BaseButton. I also removed some duplicated code.Resolves #37876
Alternatively we could make the signal not emitted in
set_value(), but that's a very breaking change (and should also be done in BaseButton for consistency).I think we have a few places where the new method could be useful.