[stable/pgadmin] upgrade to 4.17 and more by rowanruseler · Pull Request #20211 · helm/charts

rowanruseler · 2020-01-17T11:03:24Z

4.17:
with 4.16 and up USER: pgadmin got added to the Dockerfile, this
caused an ACL issue. securityContext and initContainers is added to
resolve this issue.

other:

fixed dynamic PV provisioning
livenessProbe
readinessProbe
added more comments in values.yaml
updated README.md with new configuration items
chart bump version

Signed-off-by: Rowan Ruseler rowanruseler@gmail.com

4.17: with 4.16 and up `USER: pgadmin` got added to the Dockerfile, this caused an ACL issue. securityContext and initContainers is added to resolve this issue. other: - fixed dynamic PV provisioning - livenessProbe - readinessProbe - added more comments in values.yaml - updated README.md with new configuration items - chart bump version Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>

k8s-ci-robot · 2020-01-17T11:03:39Z

Hi @rowanruseler. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zanhsieh · 2020-01-18T01:28:14Z

/ok-to-test

davidkarlsen · 2020-01-20T11:33:54Z

-        {{- toYaml . | nindent 8 }}
+        {{- .Values.affinity | toYaml | nindent 8 }}
    {{- end }}
-    {{- with .Values.tolerations }}


more of a personal taste - but I favour using with as it is easier to read and keep consistent due to no duplication.

Would you like me to adjust this? Personally I found this statement more clear. But I don't mind adjusting it back.

davidkarlsen · 2020-01-20T11:35:51Z

@@ -1,19 +1,26 @@
-{{- if and .Values.persistence.enabled (not .Values.persistence.existingClaim) }}


See https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md for info on persistence

made a mistake with naming the variable different then what is shown in the values.yml example Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>

resolved sessions bug by letting the probes go to the correct path Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>

prydonius

/lgtm

k8s-ci-robot · 2020-01-31T18:05:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prydonius, rowanruseler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [prydonius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* [stable/pgadmin] upgrade to 4.17 and more 4.17: with 4.16 and up `USER: pgadmin` got added to the Dockerfile, this caused an ACL issue. securityContext and initContainers is added to resolve this issue. other: - fixed dynamic PV provisioning - livenessProbe - readinessProbe - added more comments in values.yaml - updated README.md with new configuration items - chart bump version Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com> * [stable/pgadmin] adjusted storageclass name made a mistake with naming the variable different then what is shown in the values.yml example Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com> * [stable/pgadmin] resolved sessions bug by letting the probes go to the correct path Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com> Signed-off-by: Sergio Borges <sergio.borges@safetyculture.io>

…tainer * upstream/master: (309 commits) [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523) [stable/prometheus-redis-exporter] Update image for exporter (helm#19317) update alantis version (helm#20507) [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517) [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409) Allow DNS egress to resolve hostnames (helm#20437) [stable/rabbitmq] Add PrometheusRule. (helm#20478) [stable/drupal] Release 6.2.4 updating components versions (helm#20491) [stable/metabase] interpolate liveness and readiness probes (helm#20475) [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490) [stable/gocd] Quote ingress host (helm#20477) [stable/metabase] allow setting jetty options (helm#20456) [stable/pgadmin] upgrade to 4.17 and more (helm#20211) [stable/prometheus-operator] add apiserverConfig (helm#20453) [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464) Add annotation support to pushgateway service (helm#20351) Upgrade nfs-provisioner to v2.3.0 (helm#20468) [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471) [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467) [stable/redis] Add PrometheusRule. (helm#20388) ...

* [stable/pgadmin] upgrade to 4.17 and more 4.17: with 4.16 and up `USER: pgadmin` got added to the Dockerfile, this caused an ACL issue. securityContext and initContainers is added to resolve this issue. other: - fixed dynamic PV provisioning - livenessProbe - readinessProbe - added more comments in values.yaml - updated README.md with new configuration items - chart bump version Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com> * [stable/pgadmin] adjusted storageclass name made a mistake with naming the variable different then what is shown in the values.yml example Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com> * [stable/pgadmin] resolved sessions bug by letting the probes go to the correct path Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jan 17, 2020

k8s-ci-robot requested review from mattfarina and prydonius January 17, 2020 11:03

helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2020

k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2020

davidkarlsen reviewed Jan 20, 2020

View reviewed changes

rowanruseler added 2 commits January 21, 2020 09:39

[stable/pgadmin] adjusted storageclass name

5c8ad58

made a mistake with naming the variable different then what is shown in the values.yml example Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>

[stable/pgadmin]

7ec2669

resolved sessions bug by letting the probes go to the correct path Signed-off-by: Rowan Ruseler <rowanruseler@gmail.com>

prydonius approved these changes Jan 31, 2020

View reviewed changes

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020

k8s-ci-robot merged commit e71080f into helm:master Jan 31, 2020

rowanruseler deleted the rr/pgadmin-4.17 branch February 5, 2020 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/pgadmin] upgrade to 4.17 and more#20211

[stable/pgadmin] upgrade to 4.17 and more#20211
k8s-ci-robot merged 3 commits intohelm:masterfrom
rowanruseler:rr/pgadmin-4.17

rowanruseler commented Jan 17, 2020

Uh oh!

k8s-ci-robot commented Jan 17, 2020

Uh oh!

zanhsieh commented Jan 18, 2020

Uh oh!

davidkarlsen Jan 20, 2020

Uh oh!

rowanruseler Jan 21, 2020

Uh oh!

davidkarlsen Jan 20, 2020

Uh oh!

prydonius left a comment

Uh oh!

k8s-ci-robot commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		@@ -1,19 +1,26 @@
		{{- if and .Values.persistence.enabled (not .Values.persistence.existingClaim) }}

Conversation

rowanruseler commented Jan 17, 2020

Uh oh!

k8s-ci-robot commented Jan 17, 2020

Uh oh!

zanhsieh commented Jan 18, 2020

Uh oh!

davidkarlsen Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

rowanruseler Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

davidkarlsen Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

prydonius left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants