Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/metabase] interpolate liveness and readiness probes#20475

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
kl4w:metabase-deployment-probes
Feb 3, 2020
Merged

[stable/metabase] interpolate liveness and readiness probes#20475
k8s-ci-robot merged 1 commit intohelm:masterfrom
kl4w:metabase-deployment-probes

Conversation

@kl4w
Copy link
Copy Markdown
Contributor

@kl4w kl4w commented Jan 31, 2020

Signed-off-by: Kash Law ka.shing.law@gmail.com

What this PR does / why we need it:

Allows modification of the values of the liveness and readiness probe. In our case, we'd like to modify the liveness probe.

Which issue this PR fixes

Special notes for your reviewer:

Change is a no-op compared to the original template. I've also got another PR for this chart that has bumped up the same patch version (#20456). Let me know how you'd like me to handle this and I'll make the necessary change.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Jan 31, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 31, 2020

Hi @kl4w. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2020
@pmint93
Copy link
Copy Markdown
Collaborator

pmint93 commented Feb 2, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2020
@pmint93
Copy link
Copy Markdown
Collaborator

pmint93 commented Feb 2, 2020

@kl4w Can you please bump the chart version again, due to current conflict

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 2, 2020
@kl4w
[stable/metabase] interpolate liveness and readiness probes
7fc08db 
Signed-off-by: Kash Law <ka.shing.law@gmail.com>
@kl4w kl4w force-pushed the metabase-deployment-probes branch from 19f4e9d to 7fc08db Compare February 3, 2020 04:57
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 3, 2020
@kl4w
Copy link
Copy Markdown
Contributor Author

kl4w commented Feb 3, 2020

@pmint93 updated chart version and rebased

@pmint93
Copy link
Copy Markdown
Collaborator

pmint93 commented Feb 3, 2020

/approve
/lgtm

Thanks for your contribution ;)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kl4w, pmint93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7566d6d into helm:master Feb 3, 2020
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge remote-tracking branch 'upstream/master' into add_superset_main…
51c5fba 
…tainer

* upstream/master: (309 commits)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  [stable/metabase] interpolate liveness and readiness probes (helm#20475)
  [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
  [stable/gocd] Quote ingress host (helm#20477)
  [stable/metabase] allow setting jetty options (helm#20456)
  [stable/pgadmin] upgrade to 4.17 and more (helm#20211)
  [stable/prometheus-operator] add apiserverConfig (helm#20453)
  [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)
  Add annotation support to pushgateway service (helm#20351)
  Upgrade nfs-provisioner to v2.3.0 (helm#20468)
  [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471)
  [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467)
  [stable/redis] Add PrometheusRule. (helm#20388)
  ...
alexppg pushed a commit to alexppg/charts that referenced this pull request Feb 4, 2020
@kl4w @alexppg
[stable/metabase] interpolate liveness and readiness probes (helm#20475)
fce831d 
Signed-off-by: Kash Law <ka.shing.law@gmail.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@kl4w
[stable/metabase] interpolate liveness and readiness probes (helm#20475)
4728b51 
Signed-off-by: Kash Law <ka.shing.law@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lachie83 lachie83 Awaiting requested review from lachie83

1 more reviewer

@pmint93 pmint93 pmint93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kl4w @k8s-ci-robot @pmint93 @helm-bot