Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/graylog] Add helm2Compatibility flag to values.yaml that preserves specific labels installed by helm2 for backward compatibility#20464

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
juliohm1978:master
Jan 31, 2020
Merged

Conversation

@juliohm1978
Copy link
Copy Markdown
Contributor

@juliohm1978 juliohm1978 commented Jan 31, 2020

What this PR does / why we need it:

Releases installed from this chart using helm2 cannot be upgraded after migrating to helm3.

Using helm2, the chart renders the label app.kubernetes.io/managed-by: Tiller in the Graylog StatefulSet. Meanwhile, using helm3, the chart renders app.kubernetes.io/managed-by: "Helm".

Since Kubernetes considers the field .spec.template.metadata.label immutable for StatefulSets, upgrading migrated releases is not possible without a complete purge/reinstall.

The attempt to upgrade results in the following error message:

Error: UPGRADE FAILED: cannot patch "graylog-deploy" with kind StatefulSet: StatefulSet.apps "graylog-deploy" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden

This PR adds the flag helm2Compatibility to values.yaml, giving users the choice to preserve related label fields. This allows upgrades to continue without a complete purge/reinstall of the current release.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

[stable/graylog] Fix #20306, add helm2Compatibility flag to `values…
29819ae 
….yaml` that preserves specific labels installed by helm2 for backward compatibility.

Signed-off-by: juliohm1978 <jhm@juliohm.com.br>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 31, 2020

Hi @juliohm1978. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2020
@juliohm1978 juliohm1978 mentioned this pull request Jan 31, 2020
Closed
@KongZ
Copy link
Copy Markdown
Collaborator

KongZ commented Jan 31, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2020
@KongZ
Copy link
Copy Markdown
Collaborator

KongZ commented Jan 31, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliohm1978, KongZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit f9eedf2 into helm:master Jan 31, 2020
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 3, 2020
[stable/graylog] Fix helm#20306, add helm2Compatibility flag to `va…
cc989f2 
…lues.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)

Signed-off-by: juliohm1978 <jhm@juliohm.com.br>
Signed-off-by: Sergio Borges <sergio.borges@safetyculture.io>
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 4, 2020
[stable/graylog] Fix helm#20306, add helm2Compatibility flag to `va…
969c35f 
…lues.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)

Signed-off-by: juliohm1978 <jhm@juliohm.com.br>
Signed-off-by: Sergio Borges <sergio.borges@safetyculture.io>
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge remote-tracking branch 'upstream/master' into add_superset_main…
51c5fba 
…tainer

* upstream/master: (309 commits)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  [stable/metabase] interpolate liveness and readiness probes (helm#20475)
  [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
  [stable/gocd] Quote ingress host (helm#20477)
  [stable/metabase] allow setting jetty options (helm#20456)
  [stable/pgadmin] upgrade to 4.17 and more (helm#20211)
  [stable/prometheus-operator] add apiserverConfig (helm#20453)
  [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)
  Add annotation support to pushgateway service (helm#20351)
  Upgrade nfs-provisioner to v2.3.0 (helm#20468)
  [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471)
  [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467)
  [stable/redis] Add PrometheusRule. (helm#20388)
  ...
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
[stable/graylog] Fix helm#20306, add helm2Compatibility flag to `va…
985f03c 
…lues.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)

Signed-off-by: juliohm1978 <jhm@juliohm.com.br>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

@KongZ KongZ Awaiting requested review from KongZ

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[stable/graylog] Release installed with helm2 cannot be upgraded using helm3

4 participants

@juliohm1978 @k8s-ci-robot @KongZ @helm-bot