Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Fix a typo in the Grafana chart notes#20490

Merged
k8s-ci-robot merged 2 commits intohelm:masterfrom
emedvedev:patch-1
Feb 3, 2020
Merged

[stable/grafana] Fix a typo in the Grafana chart notes#20490
k8s-ci-robot merged 2 commits intohelm:masterfrom
emedvedev:patch-1

Conversation

@emedvedev
Copy link
Copy Markdown
Contributor

@emedvedev emedvedev commented Feb 1, 2020 •
edited
Loading

What this PR does / why we need it:

Fixes a small typo in the notes :) "grafanfa" -> "grafana"

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@k8s-ci-robot k8s-ci-robot requested a review from zanhsieh February 1, 2020 22:23
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 1, 2020

Hi @emedvedev. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@emedvedev
Fix a typo in the Grafana chart notes
c018b06 
Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 1, 2020
@zanhsieh
Copy link
Copy Markdown
Collaborator

zanhsieh commented Feb 2, 2020

@emedvedev
Could you bump the chart version to latest please? Thank you.
/assign

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 2, 2020
@emedvedev
[stable/grafana] Bump the chart version
84d0ed5 
Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Feb 2, 2020
@emedvedev
Copy link
Copy Markdown
Contributor Author

emedvedev commented Feb 2, 2020

@zanhsieh done :)

@zanhsieh
Copy link
Copy Markdown
Collaborator

zanhsieh commented Feb 2, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2020
@zanhsieh
Copy link
Copy Markdown
Collaborator

zanhsieh commented Feb 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emedvedev, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2020
@zanhsieh
Copy link
Copy Markdown
Collaborator

zanhsieh commented Feb 3, 2020

/test pull-charts-e2e

@k8s-ci-robot k8s-ci-robot merged commit 624a6a2 into helm:master Feb 3, 2020
@replicated-ship replicated-ship Bot mentioned this pull request Feb 3, 2020
Open
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 4, 2020
@emedvedev
[stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
7563455 
* Fix a typo in the Grafana chart notes

Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>

* [stable/grafana] Bump the chart version

Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>
Signed-off-by: Sergio Borges <sergio.borges@safetyculture.io>
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge remote-tracking branch 'upstream/master' into add_superset_main…
51c5fba 
…tainer

* upstream/master: (309 commits)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  [stable/metabase] interpolate liveness and readiness probes (helm#20475)
  [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
  [stable/gocd] Quote ingress host (helm#20477)
  [stable/metabase] allow setting jetty options (helm#20456)
  [stable/pgadmin] upgrade to 4.17 and more (helm#20211)
  [stable/prometheus-operator] add apiserverConfig (helm#20453)
  [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)
  Add annotation support to pushgateway service (helm#20351)
  Upgrade nfs-provisioner to v2.3.0 (helm#20468)
  [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471)
  [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467)
  [stable/redis] Add PrometheusRule. (helm#20388)
  ...
alexppg pushed a commit to alexppg/charts that referenced this pull request Feb 4, 2020
@emedvedev @alexppg
[stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
9b6d3b9 
* Fix a typo in the Grafana chart notes

Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>

* [stable/grafana] Bump the chart version

Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@emedvedev
[stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
743321f 
* Fix a typo in the Grafana chart notes

Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>

* [stable/grafana] Bump the chart version

Signed-off-by: Edward Medvedev <edward.medvedev@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanhsieh zanhsieh zanhsieh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zanhsieh zanhsieh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emedvedev @k8s-ci-robot @zanhsieh @helm-bot