-
Notifications
You must be signed in to change notification settings - Fork 387
Add image-to-image and image-generation tasks #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is cool
- Do you have a screenshot with this built just to confirm it works and how it looks like?
- I was wondering if
image-generationshould be calledunconditional-image-generationto clarify that there is no input, but I was also wondering if I might be missing something
|
cc @julien-c |
|
Thank you! Overall looks good and I think the icons are great. My only remaining question is if the task should be |
|
not super familiar with this task, but what's the input for |
|
Usually it's a noise vector (the seed is used to have consistent noise vector for consistent output) |
|
|
|
|
|
No strong opinion from my side, I think |
|
ok let's do this unless @nateraw objects then! |
|
@julien-c I think noise-to-image is actually more confusing... Basically WDYT @osanseviero |
|
Yeah it's actually only GANs that start from noise for unconditional image generation, right? Not sure how diffusion models and VAEs do this. |
|
the drawback is that for me (Note: i don't think we want to model PWC's taxonomy too much, since ours aims to be simpler) |
|
with this in mind, maybe |
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for this! 🚀
* Propose new tasks structure * Remove need for a second list just for the order * Misc fixes * Apply suggestions from code review Co-authored-by: Julien Chaumond <julien@huggingface.co> * Make data access consistent * Remove unrelated * reapply #90 * missing tweak from #90 * reapply #80 * Adopt cool typing solution from @coyotte508 #84 (comment) * npm run format * improve typings here now that we have all types? * Keep same order as in `Types.ts` to minimize diff * Ooops missing change it seems * Ok tune down the typing a little bit * Align subtasks with datasets and add field to hide a task (#86) * Re-add `PIPELINE_TAGS_DISPLAY_ORDER` to give us freedom on UX side Co-authored-by: Julien Chaumond <julien@huggingface.co>


Adds 2 new tasks to filter by:
Adding these as we will encourage folks to add these tags in the HugGAN event.
lib/was blocked in the .gitignore, so I removed it. Otherwise I would have to force add files. Hopefully that's ok 😅