Skip to content

Conversation

@nateraw
Copy link
Contributor

@nateraw nateraw commented Mar 25, 2022

Adds 2 new tasks to filter by:

  • image-to-image
  • image-generation

Adding these as we will encourage folks to add these tags in the HugGAN event.

⚠️ When completing this PR, I noticed lib/ was blocked in the .gitignore, so I removed it. Otherwise I would have to force add files. Hopefully that's ok 😅

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is cool

  • Do you have a screenshot with this built just to confirm it works and how it looks like?
  • I was wondering if image-generation should be called unconditional-image-generation to clarify that there is no input, but I was also wondering if I might be missing something

@osanseviero
Copy link
Contributor

cc @julien-c

@nateraw
Copy link
Contributor Author

nateraw commented Mar 29, 2022

As requested, here's a screenshot

Screen Shot 2022-03-29 at 12 35 47 PM

@osanseviero
Copy link
Contributor

Thank you! Overall looks good and I think the icons are great. My only remaining question is if the task should be image-generation or unconditional-image-generation (for the cases in which the image is generated from noise)

@julien-c
Copy link
Member

not super familiar with this task, but what's the input for image-generation? just a seed?

@osanseviero
Copy link
Contributor

Usually it's a noise vector (the seed is used to have consistent noise vector for consistent output)

@julien-c
Copy link
Member

unconditional-image-generation sounds weird/vague to me but I don't have a better idea right now =)

@julien-c
Copy link
Member

noise-to-image?

@osanseviero
Copy link
Contributor

No strong opinion from my side, I think noise-to-image could work as well

@julien-c
Copy link
Member

ok let's do this unless @nateraw objects then!

@nateraw
Copy link
Contributor Author

nateraw commented Mar 30, 2022

@julien-c I think noise-to-image is actually more confusing...unconditional-image-generation would actually fit Papers with Code's taxonomy best...my only objection to that is that the name is a little long haha.

Basically image-generation is the parent task and unconditional-image-generation and conditional-image-generation fall within it. So I vote we either stick with image-generation (because I doubt we'll end up enabling inference API for the sub-tasks since the models vary so greatly in size of the noise vectors, how conditions are chosen, etc) or we go with unconditional-image-generation to match the taxonomy on PapersWithCode.

WDYT @osanseviero

@NielsRogge
Copy link
Contributor

NielsRogge commented Mar 30, 2022

Yeah it's actually only GANs that start from noise for unconditional image generation, right? Not sure how diffusion models and VAEs do this. noise-to-image is probably too GAN-specific

@julien-c
Copy link
Member

the drawback is that for me image-generation is very easily confused with text-to-image

(Note: i don't think we want to model PWC's taxonomy too much, since ours aims to be simpler)

@julien-c
Copy link
Member

with this in mind, maybe unconditional-image-generation is the best one then yes =)

@nateraw
Copy link
Contributor Author

nateraw commented Mar 30, 2022

Done. Screenshot here for your viewing pleasure.

Screen Shot 2022-03-30 at 12 44 02 PM

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this! 🚀

@nateraw nateraw merged commit fda9e1d into main Mar 31, 2022
@nateraw nateraw deleted the gan-tasks branch March 31, 2022 14:20
julien-c added a commit that referenced this pull request Apr 12, 2022
osanseviero added a commit that referenced this pull request Apr 12, 2022
* Propose new tasks structure

* Remove need for a second list just for the order

* Misc fixes

* Apply suggestions from code review

Co-authored-by: Julien Chaumond <julien@huggingface.co>

* Make data access consistent

* Remove unrelated

* reapply #90

* missing tweak from #90

* reapply #80

* Adopt cool typing solution from @coyotte508

#84 (comment)

* npm run format

* improve typings here now that we have all types?

* Keep same order as in `Types.ts` to minimize diff

* Ooops missing change it seems

* Ok tune down the typing a little bit

* Align subtasks with datasets and add field to hide a task (#86)

* Re-add `PIPELINE_TAGS_DISPLAY_ORDER` to give us freedom on UX side

Co-authored-by: Julien Chaumond <julien@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants