-
Notifications
You must be signed in to change notification settings - Fork 387
New task structure #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
julien-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few first comments!
js/src/lib/components/InferenceWidget/shared/WidgetHeader/WidgetHeader.svelte
Outdated
Show resolved
Hide resolved
js/src/lib/components/InferenceWidget/shared/WidgetHeader/WidgetHeader.svelte
Outdated
Show resolved
Hide resolved
|
@Pierrci @coyotte508 when you have some time (not urgent), can you take a look at the specific question of: whether we want to type things like in this current PR, or do |
How it's done here is perfectly fine for me. But we can have the best of both worlds if you want :) |
|
reminder to self to read @coyotte508's comment on Monday |
Co-authored-by: Julien Chaumond <julien@huggingface.co>
|
i have rebased this branch on (as new tasks were added in the meantime) |
|
PS/ @coyotte508's typing solution works and is very cool 👍 |
|
Feel free to push to this branch! |
julien-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modulo re-adding a PIPELINE_TAGS_DISPLAY_ORDER (that we can change to feature more non-NLP stuff) this LGTM! 🚢
julien-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this is ready to merge i think!
|
Should we wait until moon landing PR is ready before merging? |
|
no i think we can merge this and I'll rebase/finish the moon-landing PR this afternoon 👍 |
First part of 4 for #83
Internal change at https://github.com/huggingface/moon-landing/pull/2514
This PR changes how we define the types into a way that is better structured, more flexible, and give us more control (e.g. define if we want to show a type just in models or just in datasets).
One user-facing change is the order in which the tags are displayed. I'm happy to revert to previous impl if that's wanted.
Some TODOs/questions
PipelineType, we can instead defineconst ALL_PIPELINE_TYPES = [ "text-classification", ... ] as const;and thenconst PIPELINES: Record<PipelineType, PipelineData> = { ... }, I left this one as it worked fine and you just have to define the task in a single place. Maybe the other approach was preferredPIPELINE_TAGS_DISPLAY_ORDER[]s since they are optionalSome screenshots showing unaffected changes