Align subtasks with datasets and add field to hide a task #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
approved these changes
Apr 12, 2022
(cherry picked from commit 9d125f1)
Member
|
Ok I pushed --force and rebased on top of the rebased branch =) This should be ready to merge! |
osanseviero
added a commit
that referenced
this pull request
Apr 12, 2022
* Propose new tasks structure * Remove need for a second list just for the order * Misc fixes * Apply suggestions from code review Co-authored-by: Julien Chaumond <julien@huggingface.co> * Make data access consistent * Remove unrelated * reapply #90 * missing tweak from #90 * reapply #80 * Adopt cool typing solution from @coyotte508 #84 (comment) * npm run format * improve typings here now that we have all types? * Keep same order as in `Types.ts` to minimize diff * Ooops missing change it seems * Ok tune down the typing a little bit * Align subtasks with datasets and add field to hide a task (#86) * Re-add `PIPELINE_TAGS_DISPLAY_ORDER` to give us freedom on UX side Co-authored-by: Julien Chaumond <julien@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of 4 for #83
Add subtasks based on huggingface/datasets#4066 and add field to hide from filters at left.
Note: this does not add all tasks from huggingface/datasets#4066, just the subtasks, since adding tasks requires some additional effort to add icons and a couple of other things. The hide will require an additional internal PR.
cc @lhoestq