Update app.html code#1091
Closed
ImJacobChen wants to merge 1 commit into
Closed
Conversation
The code displayed was not the code that is displayed when you start an ionic2 app.
janpio
approved these changes
May 13, 2017
haxwell
approved these changes
Jun 13, 2018
Contributor
haxwell
left a comment
haxwell
left a comment
There was a problem hiding this comment.
I created a sample app, and ran through the tutorial instruction on the ionicframework.com up to the point of this PR. The changes in this PR are accurate, and reflect what is generated by the CLI.
This was referenced Jun 13, 2018
mhartington
pushed a commit
that referenced
this pull request
Jun 13, 2018
) * PR #1091 initially made this change, but was in a conflict state. I created this new PR to address the conflict, and get this change in. * Per @perrygovier comment, I added back the {% raw %} tags, used in Jekyll processing
Contributor
|
@mhartington FYI, this should be closed. #1383 addressed this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code displayed was not the code that is displayed when you start an ionic2 app.