Skip to content

Updated Docs with generated code#1107

Closed
marcorieser wants to merge 1 commit into
ionic-team:masterfrom
marcorieser:patch-1
Closed

Updated Docs with generated code#1107
marcorieser wants to merge 1 commit into
ionic-team:masterfrom
marcorieser:patch-1

Conversation

@marcorieser
Copy link
Copy Markdown

No description provided.

@janpio
Copy link
Copy Markdown
Contributor

janpio commented May 22, 2017

Could you explain a bit what exactly you changed and why you?

@marcorieser
Copy link
Copy Markdown
Author

Because i generated the tutorial project with the cli and the generated code was not like the docs (https://ionicframework.com/docs//intro/tutorial/project-structure/) so i changed the docs to be the same like the generated code. By the way on the next page (https://ionicframework.com/docs//intro/tutorial/adding-pages/) the ion-nav already has the reference to #content like i changed it.

@joaquintoral
Copy link
Copy Markdown

@marcorieser, @janpio same thing for the getting started page. The generated code do not match the codes written in the getting started part of the documentation and so on.

@janpio
Copy link
Copy Markdown
Contributor

janpio commented Jun 23, 2017

@joaquintoral Feel free to submit a PR changing that yourself.

@haxwell
Copy link
Copy Markdown
Contributor

haxwell commented Jun 13, 2018

This change was originally made in #1091, but over time that came to be in a conflict state. It is now addressed in PR #1383. Once 1383 is committed, both this issue and 1091 should be closed.

@haxwell
Copy link
Copy Markdown
Contributor

haxwell commented Jun 13, 2018

@mhartington FYI, this should be closed. #1383 addressed this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants