Skip to content

PR #1091 initially made this change, but was in a conflict state.#1383

Merged
mhartington merged 2 commits into
ionic-team:masterfrom
haxwell:PR-1382
Jun 13, 2018
Merged

PR #1091 initially made this change, but was in a conflict state.#1383
mhartington merged 2 commits into
ionic-team:masterfrom
haxwell:PR-1382

Conversation

@haxwell
Copy link
Copy Markdown
Contributor

@haxwell haxwell commented Jun 13, 2018

I created this new PR to address the conflict, and get this change in.

It corrects some code that appears in the online tutorial, so that what is reflected on the web site accurately represents what is generated in the CLI.

…reated this new PR to address the conflict, and get this change in.
@haxwell
Copy link
Copy Markdown
Contributor Author

haxwell commented Jun 13, 2018

Thanks to @ImJacobChen for initially making this change in PR #1091

@perrygovier perrygovier requested a review from mhartington June 13, 2018 16:26
@perrygovier
Copy link
Copy Markdown
Contributor

perrygovier commented Jun 13, 2018

I'll let @mhartington verify the rest, but the {% raw %} tags are required for escaping when Jekyll parses the markdown

@haxwell
Copy link
Copy Markdown
Contributor Author

haxwell commented Jun 13, 2018

OK... I removed them because they didn't appear in the generated source code. I'll watch out for those tags in other PRs I review/submit. Thanks!

@mhartington mhartington merged commit 4cf2065 into ionic-team:master Jun 13, 2018
@haxwell haxwell mentioned this pull request Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants