feat(icon): add font icon support to ion-icon - #1499
Merged
Conversation
This reverts commit a912828.
brandyscarney
commented
Jul 23, 2026
|
|
||
| .icon-inner, | ||
| .icon-inner { | ||
| display: flex; |
Member
Author
There was a problem hiding this comment.
We need flex here for the font icons, otherwise they are shifted to the right and down. Since developers can't override this, we could expose this as a part if it's an issue.
brandyscarney
commented
Jul 23, 2026
brandyscarney
commented
Jul 23, 2026
ShaneK
requested changes
Jul 24, 2026
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looking good! Just a thing I noticed, but I could be off base here
thetaPC
approved these changes
Jul 28, 2026
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just minor question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for slotted content in the
ion-iconcomponent, enabling developers to use custom icons via any content type: font icons, SVGs, or other icon components.Change Type
Rationale / Problems Fixed
Provides flexibility for developers who want to use custom icon implementations alongside SVG icons. The slotted content support allows the
ion-iconcomponent to wrap and style various icon formats (font icons, custom SVGs, icon components) with a unified interface, while developers benefit from all of the ionic framework component styling applied toion-icon.Implementation Details
<slot></slot>support to theion-iconcomponent JSX to accept slotted contentcontain: stricttocontain: layout styleto allow better integration with slotted content::slotted(*)styles to inherit font size from the host element for proper sizingExample Usage
Dev Build
8.0.14-dev.11785269740.1e15c0b8