Jarlungoodoo73 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felix Weinberger <3823880+felixweinberger@users.noreply.github.com>
…ocol#904) Co-authored-by: David Soria Parra <167242713+dsp-ant@users.noreply.github.com>
…ol#922) Co-authored-by: David Soria Parra <167242713+dsp-ant@users.noreply.github.com>
…and add explicit resourceServerUrl (RFC 9728) (modelcontextprotocol#858) Co-authored-by: Eugene <eugene@blust.ai>
…ul authentication (modelcontextprotocol#945) Co-authored-by: Vinicius Costa <viniciuscsouza@yahoo.com.br> Co-authored-by: Tyler James Leonhardt <2644648+TylerLeonhardt@users.noreply.github.com> Co-authored-by: Blust.AI <159488814+blustAI@users.noreply.github.com> Co-authored-by: Eugene <eugene@blust.ai>
…ntationSchema use IconsSchema (modelcontextprotocol#947)
Co-authored-by: ihrpr <inna@anthropic.com>
…f stateless HTTP, explain tools v resources v prompts (modelcontextprotocol#980)
Co-authored-by: Matt <77928207+mattzcarey@users.noreply.github.com> Co-authored-by: Matt Carey <mcarey@cloudflare.com>
…Http.ts and sse.ts) to allow requests without an Origin, as they are not relevant to server DNS rebinding protection. (modelcontextprotocol#1205)
* Add secure default for DNS rebinding, use in examples * Update README examples to use createMcpExpressApp, bump to 1.23.0 - Update all server examples to use createMcpExpressApp() for secure defaults - Rewrite DNS Rebinding Protection section to document new middleware approach - Bump version from 1.23.0-beta.0 to 1.23.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Add IPv6 support, allowedHosts option, and warning for unprotected servers - Use native URL API to parse Host headers (handles IPv6 correctly) - Add [::1] (IPv6 localhost) to localhostHostValidation - Add ::1 to list of localhost hosts that get automatic protection - Add allowedHosts option to createMcpExpressApp for custom host validation - Warn when binding to 0.0.0.0 or :: without allowedHosts configured - Add tests for IPv6 and allowedHosts functionality 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Update remaining examples to use createMcpExpressApp and add DNS rebinding docs - Update simpleTaskInteractive.ts, ssePollingExample.ts, and elicitationUrlExample.ts to use createMcpExpressApp() instead of express() + express.json() - Add DNS rebinding protection section to docs/server.md explaining how to use createMcpExpressApp() and hostHeaderValidation middleware 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
…modelcontextprotocol#1216) Co-authored-by: Felix Weinberger <fweinberger@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Konstantin Konstantinov <konstantin@mach5technology.com>
Co-authored-by: Konstantin Konstantinov <KKonstantinov@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
…up across 1 directory (modelcontextprotocol#1228) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Jabidahs/typescript-sdk
jarlungoodoo73
added
bug
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We failed to fetch the diff for pull request #1
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
There was a problem hiding this comment.
Pull request overview
This PR, titled "Jarlungoodoo73", appears to be a comprehensive refactoring and feature enhancement focusing on code formatting, modernization, and the addition of experimental task support. Based on the referenced discussion, this is likely addressing code quality and consistency improvements across the TypeScript SDK.
Key changes:
- Formatting improvements: Converting double quotes to single quotes, fixing indentation and whitespace inconsistencies
- Modernization: Updating import patterns (e.g.,
import * as z from 'zod/v4'and removing unused imports) - New features: Adding experimental task support with client-side task APIs, elicitation examples, and OAuth extensions
Reviewed changes
Copilot reviewed 64 out of 159 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/experimental/tasks/client.ts | New file introducing experimental client task features including streaming tool calls and task management |
| src/experimental/index.ts | New experimental module export file |
| src/examples/shared/inMemoryEventStore.ts | Formatting fixes (semicolons, line breaks) |
| src/examples/server/*.ts | Multiple server examples updated with formatting fixes, import modernization, and new elicitation/task examples |
| src/examples/client/*.ts | Multiple client examples updated with formatting fixes and new examples for tasks, elicitation, and OAuth |
| src/examples/README.md | Documentation updates for new examples and features |
| src/client/*.ts | Client transport implementations updated with formatting, auth improvements, and bug fixes |
| src/cli.ts | File removed (deprecated CLI) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
You wanted collaboration you got it, Github Community roll up your sleeves . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jabidahscreationssystems-com#1 (comment)