Skip to content

Translate 1-js/02-first-steps/08-comparison#115

Merged
iliakan merged 2 commits into
javascript-tutorial:masterfrom
RangerDin:first-steps_comparison
May 6, 2019
Merged

Translate 1-js/02-first-steps/08-comparison#115
iliakan merged 2 commits into
javascript-tutorial:masterfrom
RangerDin:first-steps_comparison

Conversation

@RangerDin

@RangerDin RangerDin commented Apr 28, 2019

Copy link
Copy Markdown
Contributor

Перевел статью и задачу.

@CLAassistant

CLAassistant commented Apr 28, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread 1-js/02-first-steps/08-comparison/1-comparison-questions/task.md Outdated
Comment thread 1-js/02-first-steps/08-comparison/article.md Outdated
Comment thread 1-js/02-first-steps/08-comparison/article.md Outdated
@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Apr 30, 2019
@javascript-translate-bot

Copy link
Copy Markdown
Contributor

Please make requested changes. After it, add a comment "/done".
I'll ask for a new review 👻

@RangerDin

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Apr 30, 2019
Comment thread 1-js/02-first-steps/08-comparison/article.md Outdated
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Apr 30, 2019
@javascript-translate-bot

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@RangerDin RangerDin force-pushed the first-steps_comparison branch 2 times, most recently from c5affd5 to a5645e5 Compare May 1, 2019 09:55
@RangerDin

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 1, 2019
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels May 1, 2019

@iliakan iliakan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пожалуйста, внеси изменения.

Comment thread 1-js/02-first-steps/08-comparison/article.md
Comment thread 1-js/02-first-steps/08-comparison/article.md Outdated
Comment thread 1-js/02-first-steps/08-comparison/article.md Outdated
Comment thread 1-js/02-first-steps/08-comparison/article.md Outdated
@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label May 6, 2019
@javascript-translate-bot

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@RangerDin RangerDin force-pushed the first-steps_comparison branch from a5645e5 to afabed0 Compare May 6, 2019 12:46
@RangerDin

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 6, 2019

@iliakan iliakan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini-fix

Comment thread 1-js/02-first-steps/08-comparison/article.md Outdated
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 6, 2019
@javascript-translate-bot

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@iliakan

iliakan commented May 6, 2019

Copy link
Copy Markdown
Member

Плиз не надо форс пушить =)

@iliakan

iliakan commented May 6, 2019

Copy link
Copy Markdown
Member

Я при этом не могу посмотреть изменения с последнего ревью.

@RangerDin

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 6, 2019
@iliakan

iliakan commented May 6, 2019

Copy link
Copy Markdown
Member

👍

@iliakan iliakan merged commit 3b391b3 into javascript-tutorial:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 One more review needed review needed Review needed, please approve or request changes work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants