File and FileReader by shchegol · Pull Request #215 · javascript-tutorial/ru.javascript.info

shchegol · 2019-05-29T12:29:06Z

Предлагаю следующий вариант перевода.

javascript-translate-bot · 2019-05-29T12:29:11Z

Error: the article has another translator @shchegol in the Progress Issue #60. Please update the progress issue or ask @translate-ru to do so.

shchegol · 2019-05-29T12:34:24Z

@iliakan

В статье ничего нет о том, что FileReader читает содержимое файлов асинхронно.
Для FileReader вместо w3 можно дать ссылку на русский MDN

javascript-translate-bot · 2019-05-29T13:05:15Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

shchegol · 2019-05-29T13:41:08Z

/done

javascript-translate-bot · 2019-05-29T13:47:32Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

shchegol · 2019-05-29T14:04:39Z

/done

javascript-translate-bot · 2019-05-29T14:38:50Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

shchegol · 2019-05-29T15:16:46Z

/done

shchegol · 2019-05-29T15:18:42Z

Чёт я не то сделал похоже...

iliakan

Спасибо, пожалуйста, внеси небольшие изменения =)

javascript-translate-bot · 2019-05-29T18:38:30Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

shchegol · 2019-05-30T06:39:07Z

/done

iliakan · 2019-05-30T06:44:42Z

Разрешил конфликты.
Не понимаю, почему done, ведь правки не были учтены, посмотри их плиз @shchegol

iliakan · 2019-05-30T07:45:28Z

@shchegol в статье есть про то, что данные приходят через события (=> асинхронно), этого не хватает?

shchegol · 2019-05-30T08:44:29Z

@iliakan

Я сейчас всё перепроверил, не могу найти, какие исправления я ещё не учёл? В последнем 726d889 коммите я вроде бы все предложенные тобой исправления внёс.
Про эту фразу: Данные передаются при помощи событий, так как чтение с диска может занять время. - вот сейчас я до конца понял что имелось ввиду, сначала нет.

javascript-translate-bot · 2019-05-30T09:01:59Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

shchegol · 2019-05-30T09:09:12Z

/done

iliakan · 2019-05-30T09:30:16Z

🚀

javascript-translate-bot · 2019-05-30T09:30:20Z

Error: the article has another translator @shchegol , not @shchegol in the Progress Issue #60. Please update the progress issue or ask maintainers to do so.

4-binary/04-file ru translation: done

1d6a554

javascript-translate-bot added the review needed Review needed, please approve or request changes label May 29, 2019

javascript-translate-bot requested a review from a team May 29, 2019 12:29

4-binary/04-file ru translation: edits

35ebb06

xcurveballx requested changes May 29, 2019

View reviewed changes

javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 29, 2019

4-binary/04-file ru translation: edits

a1a1f7f

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 29, 2019

xcurveballx requested changes May 29, 2019

View reviewed changes

Comment thread 4-binary/04-file/article.md Outdated

javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 29, 2019

4-binary/04-file ru translation: edits

7f996db

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 29, 2019

xcurveballx approved these changes May 29, 2019

View reviewed changes

javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels May 29, 2019

lex111 requested changes May 29, 2019

View reviewed changes

javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label May 29, 2019

4-binary/04-file ru translation: edits

e961134

javascript-translate-bot requested a review from a team May 29, 2019 15:16

iliakan requested changes May 29, 2019

View reviewed changes

javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 29, 2019

4-binary/04-file ru translation: edits

726d889

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 30, 2019

javascript-translate-bot requested a review from a team May 30, 2019 06:39

Merge branch 'master' into master

c4a27d6

iliakan added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 30, 2019

shchegol added 2 commits May 30, 2019 11:49

4-binary/04-file ru translation: edits

8973695

Merge branch 'master' of https://github.com/shchegol/ru.javascript.info

7a33559

iliakan requested changes May 30, 2019

View reviewed changes

Comment thread 4-binary/04-file/article.md Outdated

4-binary/04-file ru translation: edits

5361378

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 30, 2019

javascript-translate-bot requested a review from a team May 30, 2019 09:09

javascript-translate-bot merged commit 2651b4a into javascript-tutorial:master May 30, 2019

iliakan mentioned this pull request May 30, 2019

Russian Translation Progress #60

Closed

Uh oh!

Conversation

shchegol commented May 29, 2019

Uh oh!

javascript-translate-bot commented May 29, 2019

Uh oh!

shchegol commented May 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented May 29, 2019

Uh oh!

shchegol commented May 29, 2019

Uh oh!

Uh oh!

javascript-translate-bot commented May 29, 2019

Uh oh!

shchegol commented May 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented May 29, 2019

Uh oh!

shchegol commented May 29, 2019

Uh oh!

shchegol commented May 29, 2019

Uh oh!

iliakan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented May 29, 2019

Uh oh!

shchegol commented May 30, 2019

Uh oh!

iliakan commented May 30, 2019

Uh oh!

iliakan commented May 30, 2019

Uh oh!

shchegol commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented May 30, 2019

Uh oh!

shchegol commented May 30, 2019

Uh oh!

iliakan commented May 30, 2019

Uh oh!

javascript-translate-bot commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

shchegol commented May 29, 2019 •

edited

Loading

shchegol commented May 30, 2019 •

edited

Loading