Sync with upstream @ e4e6a50b#987
Closed
javascript-translate-bot wants to merge 986 commits into
Closed
Conversation
fix: removed , from solution.md and task.md for date data types
Corrected Grammar
Fix typos
fix: 2 stray lines of russian and a typo
fix: fix markdown highlight
Fix minor type error
Minor statement change
Fix error in 1-js/11-async/05-promise-api/article.md
Update solution of 1-js/02-first-steps/01-hello-world/1-hello-alert
Fix some type error
Match the solution with the question on "Type conversions" task
Grammar and typo fix in pointer events
…ct/5-sum-many-brackets I used the solution and examples already in the article. I chose to make the test cases use Array.reduce() to compute the sum, instead of hard-coding the answer myself. Not sure how good of practice that is.
…vascript.info into testcases/function-object-5
The `createMessageUnder()` function below needs the `bottom` coordinate, but it doesn't in the result of `getCoords()`.
Fixed Wikipedia link and list markdown
`openRequest.result.version` in `onupgradeneeded` is not the current DB version. It is the requested version, equal to `event.newVersion`. `event.oldVersion` contains the current version.
Fixed onupgradeneeded handling
Testcases/function object 5
Calling throttle before setting the fake timers will break any implementations that save a timestamp outside the wrapper function.
Set fake timers before calling throttle
Add bottom and right properties for getCoords()
Correct misspelling retarteted -> retargeted
Was tempted to suggest something a bit wordier: "where it finds it and, in this case, changes it", but I thought this would do.
javascript-translate-bot
added
the
review needed
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at e4e6a50
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
Click to open a list of 259 files
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterThis PR will be closed and replaced with a new one in a few days.