Skip to content

Conversation

@karrtikr
Copy link
Owner

@karrtikr karrtikr commented Oct 6, 2022

No description provided.

Kartik Raj and others added 30 commits August 8, 2022 15:42
…sues to `vscode-python` (microsoft#19656)

* Ensure any labels or assignees do not carry over when transferring issues to  repo

* Fix indent

* Make list of envs global

* Minor edit

* Run prettier

* Add Eleanor to triage flow

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>

Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Fix for JSON telemetry extraction.
Update variables in Flask Debuug Configuration
* Test server should bind to localhost.

* Fix tests.

* Some logging for easier diagnosis.
This is to classify the new call-tas-error event the Python extension
sends when calls to TAS fail.
Kartik Raj and others added 26 commits September 13, 2022 17:31
Closes microsoft#3854

Removed shebangCodeLensProvider and IShebangCodeLensProvider as well as
their references and instances. Also removed the setShebangInterpreter.
To clear property named "errortype" under the "call-tas-error" event.
Done temporarily on request of Pylance so they can begin testing.
I am removing ILanguageServer and all interfaces/types existed around it
since it seems it is no longer used.

...

it looks like ILanguageServer used to be used for old jupyter
(https://github.com/microsoft/vscode-python/blob/main/src/client/jupyter/jupyterIntegration.ts#L146)
but it no longer used by jupyter anymore
(https://github.com/microsoft/vscode-jupyter/blob/70dc27d55c95cb81bfd32a6505b7fb357bfe624e/src/platform/api/types.ts#L74).
this PR (microsoft/vscode-jupyter#10889) removed
it from jupyter since it is not used. but it is never removed from
python extension.
...

I am doing this as a part of on-going client move work since we do not
want to expose ILanguageServer to pass to jupyter extension unless it is
required.
@karrtikr karrtikr closed this Oct 6, 2022
@karrtikr karrtikr deleted the issuelable branch October 6, 2022 23:20
@karrtikr karrtikr restored the issuelable branch October 6, 2022 23:21
@karrtikr karrtikr deleted the issuelable branch October 6, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.