feat: redis data source #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes handling of undefined variations in VariationOrRollout structures. Previously, the lack of a variation was treated as 0. Instead, there is a special case that variation must be defined or else a flag is malformed.
This significantly refactors the `Variation` internal calls to be much easier to reason about. In the process, it fixes some broken behavior which is now reflected in the suppressions list. It also refactors event generation to use the `EventScope`/`EventFactory` pattern found in other SDKs, such as Rust and Go.
This removes a bunch of duplicated work from the top-level typed Variation methods, and pushes it into the internal `Variation` method.
We had an infinite loop where the `Value` tag invoke deserializer was calling the `tl::expected<Value, JsonError` version, which called back to itself. This was manifesting as a runtime infinite loop. It's not caught by contract tests since I believe the trigger is having a list of variations that are themselves arrays, like: ``` "variations": [["a","b","c",123,true,"false"], [ .. other stuff ..], ... ] ``` The fix is to break the cycle and remove the incorrect implementation.
This moves all the `_ErrorInfo_` C bindings out of the client-side SDK and into the common library, allowing them to be shared with the server. This should be backwards compatible because the `sdk.h` includes the new `error_info.h`, providing the same symbols as before.
Adds a new README for the server. Also adds a link from the client-side README to this one. --------- Co-authored-by: Molly <molly.jones@launchdarkly.com>
I hadn't wired up the `DataStoreUpdater` component, so we were just inserting flag updates directly in the memory store. With this in place, we can remove the streaming update suppression.
Implements a set of C bindings for the server-side SDK. Missing are flag notifier bindings, but this isn't implemented in the C++ side yet either.
Hooks up the initial reconnect delay parameter to the server-side streaming data source. Allows us to remove another batch of contract test failures.
The argument to `ValidChar` is a `char`, so its max value is `255` rendering the check redundant. This causes a warning on our Mac compilations as well as a linter warning. --------- Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
cwaldren-ld
commented
Dec 1, 2023
cwaldren-ld
commented
Dec 1, 2023
cwaldren-ld
commented
Dec 1, 2023
| # ./scripts/build-release launchdarkly-cpp-client | ||
|
|
||
| set -e | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is more a general issue that we build targets independently, but we require the full cmake configuration step to do so.
Might make sense to go further down this path and add LD_BUILD_SERVER and LD_BUILD_CLIENT so we can speed up CI / disable unnecessary work for people who don't want it.
cwaldren-ld
commented
Dec 1, 2023
| auto result = | ||
| boost::json::value_to<tl::expected<std::optional<Item>, JsonError>>( | ||
| json_val); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
TODO: make an actual tag_invoke deserializer for this.
cwaldren-ld
force-pushed
the
cw/sc-224112/redis-client
branch
from
4d0283e to
2c28a45
Compare
kinyoklion
reviewed
Dec 4, 2023
kinyoklion
reviewed
Dec 4, 2023
kinyoklion
reviewed
Dec 4, 2023
kinyoklion
approved these changes
Dec 4, 2023
Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a Redis data source for the server-side SDK.
When using this source, the SDK operates in what was previously known as "daemon mode". It treats Redis as read-only, loading data on-demand into an in-memory cache.
There is no connection to LaunchDarkly when using a Redis data source. That'll come later, when Redis will be able to be used as a destination.