Tag implementation improvements #3128

willgearty · 2020-10-02T16:17:57Z

This implements three major things for tags:

Converts the tuples to dictionaries in tagdict/__init__.py, which makes things like the next item much easier to add in the future.
Adds the ability to specify custom form fields/widgets/validators for specific tags for the tag UI. I've added a good number of custom fields for the tags where I though it was obvious what field type it should be or how we should validate the submitted values. There are still many that could use better validation, especially the JSON tags (maybe something from here) and the tags with a specific set of options (e.g. teacher_profile_hide_fields, see the TODO).
Removes almost all default arguments from the uses of getTag, getProgram, and getBooleanTag in favor of pulling the defaults from the tag dictionaries in tagdict/__init__.py. This should help make the defaults more consistent when tags are implemented in the future.

Fixes #2990 and fixes #2964.

esp/esp/tagdict/__init__.py

* Initial docs for stable release 13 * Docs for #3116, #3117, and #3118 * Added docs about django upgrade * Docs for #3128 * Docs for #3129, #3133, #3134, and #3137 * Docs for #3156 and #3153 * Docs for #3174, #3163, and #3184 * Docs for #3139, #3140, and #3141 * Docs for #3143, #3150, #3154, #3160, #3162, and #3168 * Docs for #3171, #3185, #3186, and #3188 * Docs for #3131 and #3189 * Docs for #3149 and #3190 * Docs for #3193, #3194, #3195, #196, and #3197 * Clarification * Docs for #3192, #3201, #3209, and #2248 * Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226 * Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239 * Fix indent * Docs for #3227 and #3235 * Add missing word * spelling * Docs for e57581f, #3255, #3253, #3257, and #3249 * Docs for #3254, #3260, and #3262 * Docs for #3263, #3272, #3240, #3264, #3266, and #3270 * clarifications * Docs for #3283 and #3252 * Docs for #3288 and misc commits * Docs for #3292, #3311, #3286, #3289, and #3279 * Docs for a377f0d; move note * Docs for #3315, #3290, and #3322 * Docs for #3273 and #3317 * Final edits

willgearty added 14 commits September 30, 2020 19:48

Convert tuples to dictionaries

6a847fc

Fix dicts

b68030e

Update models and forms to use dictionary keys

935f850

Use tagdict defaults

e0bb129

Add documentation of new behavior

143d0f8

Remove defaults from getTag

016bd6a

Add tag that was missing

77b3cc4

Remove defaults for getProgramTag

646dbf8

Remove defaults from getBooleanTag

988f70e

Allow for custom tag form fields

ffeeee7

Add some custom tag form fields

6753a48

More custom tag form fields

f6b948e

Show errors properly if form is invalid

63845d9

Update docs, add TODO

bcf323f

willgearty added UserInterface ArchitecturalChange labels Oct 2, 2020

willgearty added this to the Stable Release 13 milestone Oct 2, 2020

willgearty requested review from hwatheod, milescalabresi and kkbrum October 2, 2020 16:17

willgearty added 3 commits October 2, 2020 11:20

Convert tabs to spaces

87a8889

Fix tag tests

a67ec69

Fix getBooleanTag when a default is specified

7c738a8

willgearty changed the title ~~Tag idiot proofing~~ Tag implementation improvements Oct 2, 2020

hwatheod reviewed Oct 3, 2020

View reviewed changes

esp/esp/tagdict/__init__.py Outdated Show resolved Hide resolved

Move states list to forms init file

4db38be

willgearty requested a review from hwatheod October 6, 2020 16:11

hwatheod approved these changes Oct 9, 2020

View reviewed changes

Merge branch 'main' into tag-usage

ab11c94

willgearty merged commit 453dfef into main Oct 9, 2020

willgearty deleted the tag-usage branch October 9, 2020 14:46

willgearty added a commit that referenced this pull request Oct 9, 2020

Docs for #3128

6d291ba

Provide feedback