Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades numpy to v. 1.16.6, which is the latest version to support python 2.7. I went through the release notes for all of the releases between 1.7 and 1.16.6 to check for any glaring deprecations (we only use a handful of numpy functions almost exclusively in the class change and lottery controllers). None of the functions we currently use have been deprecated or changed in breaking ways. The only breaking change was that boolean subtraction (eww) was deprecated (good riddance). If I understand the way we were using it correctly, we just want the element-wise opposites of the boolean values in the vectors, so
~
should do the trick provided the values are always boolean. All of the lottery tests run fine, so I think everything should be okay?I also removed some extraneous imports of numpy where it was never used.
Fixes #2403.