Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user list filters #3153

Merged
merged 6 commits into from
Nov 16, 2020
Merged

New user list filters #3153

merged 6 commits into from
Nov 16, 2020

Conversation

kkbrum
Copy link
Contributor

@kkbrum kkbrum commented Nov 5, 2020

Fixes #46 and fixes #2376.

This creates user list (list gen, comm panel, and group text) filters for:

  • number of class hours of a student
  • class times of a student
  • teaching times of a teacher
  • training/interview times of a teacher
  • teachers of a particular student

Since you can now select teaching times of a teacher, this also solves the "filter for second day teachers" because you can select all the relevant time blocks for the 2nd day.

Note that I did not test the group text panel as I don't have it set up, but it is the same as the comm panel and list gen, both of which I did test.

@kkbrum kkbrum added this to the Stable Release 13 milestone Nov 5, 2020
@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2020

This pull request introduces 4 alerts when merging e892e0f into e56bb8a - view on LGTM.com

new alerts:

  • 3 for Variable defined multiple times
  • 1 for Unused import

Copy link
Member

@willgearty willgearty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few code comments. I'll actually test everything sometime today or tomorrow.

esp/esp/program/modules/handlers/commmodule.py Outdated Show resolved Hide resolved
esp/esp/program/modules/handlers/commmodule.py Outdated Show resolved Hide resolved
esp/esp/users/controllers/usersearch.py Outdated Show resolved Hide resolved
esp/esp/users/controllers/usersearch.py Outdated Show resolved Hide resolved
esp/templates/users/usersearch/list_selector.html Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2020

This pull request introduces 1 alert when merging 28bbc08 into c89464e - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Member

@willgearty willgearty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me (except for a related bug but I don't think it was caused by this PR)! Great job!

@willgearty willgearty merged commit 8d4b781 into main Nov 16, 2020
@willgearty willgearty deleted the comm-filters branch November 16, 2020 22:46
willgearty added a commit that referenced this pull request Nov 20, 2020
willgearty added a commit that referenced this pull request Mar 10, 2021
willgearty added a commit that referenced this pull request May 27, 2021
* Initial docs for stable release 13

* Docs for #3116, #3117, and #3118

* Added docs about django upgrade

* Docs for #3128

* Docs for #3129, #3133, #3134, and #3137

* Docs for #3156 and #3153

* Docs for #3174, #3163, and #3184

* Docs for #3139, #3140, and #3141

* Docs for #3143, #3150, #3154, #3160, #3162, and #3168

* Docs for #3171, #3185, #3186, and #3188

* Docs for #3131 and #3189

* Docs for #3149 and #3190

* Docs for #3193, #3194, #3195, #196, and #3197

* Clarification

* Docs for #3192, #3201, #3209, and #2248

* Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226

* Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239

* Fix indent

* Docs for #3227 and #3235

* Add missing word

* spelling

* Docs for e57581f, #3255, #3253, #3257, and #3249

* Docs for #3254, #3260, and #3262

* Docs for #3263, #3272, #3240, #3264, #3266, and #3270

* clarifications

* Docs for #3283 and #3252

* Docs for #3288 and misc commits

* Docs for #3292, #3311, #3286, #3289, and #3279

* Docs for a377f0d; move note

* Docs for #3315, #3290, and #3322

* Docs for #3273 and #3317

* Final edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comm Panel Option for Second Day Teachers Comm Panel -- new filters
2 participants