Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag to adjust date when grades increment #3143

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Conversation

willgearty
Copy link
Member

I added a new tag grade_increment_date that allows admins to adjust when student grades increment (default is July 31). This can be useful for chapters that have summer programs instead of always setting the increment_default_grade_levels tag. I've tested that dates before today maintain grades on the /userview page and dates after today result in grades - 1 on the /userview page, so it appears to be working.

image

Fixes #2392.

@willgearty willgearty added this to the Stable Release 13 milestone Oct 30, 2020
@willgearty willgearty changed the title Add tag for when grades increment Add tag to adjust date when grades increment Oct 30, 2020
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request introduces 1 alert when merging bf6389a into 481a1ec - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

esp/esp/tagdict/__init__.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Dec 17, 2020

This pull request introduces 1 alert when merging fea48c4 into 5fd87e7 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

Copy link
Contributor

@kkbrum kkbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spiffing!

@willgearty willgearty merged commit 0b58a9f into main Dec 18, 2020
@willgearty willgearty deleted the grade-increment-tag branch December 18, 2020 01:30
willgearty added a commit that referenced this pull request Dec 21, 2020
willgearty added a commit that referenced this pull request May 27, 2021
* Initial docs for stable release 13

* Docs for #3116, #3117, and #3118

* Added docs about django upgrade

* Docs for #3128

* Docs for #3129, #3133, #3134, and #3137

* Docs for #3156 and #3153

* Docs for #3174, #3163, and #3184

* Docs for #3139, #3140, and #3141

* Docs for #3143, #3150, #3154, #3160, #3162, and #3168

* Docs for #3171, #3185, #3186, and #3188

* Docs for #3131 and #3189

* Docs for #3149 and #3190

* Docs for #3193, #3194, #3195, #196, and #3197

* Clarification

* Docs for #3192, #3201, #3209, and #2248

* Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226

* Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239

* Fix indent

* Docs for #3227 and #3235

* Add missing word

* spelling

* Docs for e57581f, #3255, #3253, #3257, and #3249

* Docs for #3254, #3260, and #3262

* Docs for #3263, #3272, #3240, #3264, #3266, and #3270

* clarifications

* Docs for #3283 and #3252

* Docs for #3288 and misc commits

* Docs for #3292, #3311, #3286, #3289, and #3279

* Docs for a377f0d; move note

* Docs for #3315, #3290, and #3322

* Docs for #3273 and #3317

* Final edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grade range increment is screwed up
2 participants