Made onsite buttons #3252
Made onsite buttons #3252
Conversation
|
Fixes #3025 sorta |
|
There are 2 new functions called makeButtonLink but it's only called once in the template - which one is being called and what is the other one for? (Or somehow both are being called depending on |
|
So the first function in modules/base.py is a global function that works just like makeLink but when it makes the link it makes it a link that a button. It makes just one link per module. In handlers/onsiteclasslist.py multiple links need to be generated for that module so is has an alternate function which essentially calls makeButtonLink twice for each link that is needed. @willgearty can probably explain the technical of this better lol |
| {% else %} | ||
| <li><em>{{ module.module.link_title }} (below)</em></li> | ||
| <<em>{{ module.module.link_title }} (below)</em><br> |
There was a problem hiding this comment.
There shouldn't be two < signs here
Oh I see, the first one is used for most of the onsite modules, and the second one in a subclass which overrides the first, and is used for one particular special module. Got it. |
|
Code looks good (aside from the comments from @hwatheod). However, the page currently looks like this: This doesn't seem much better than the links from before, in my opinion. But, I think if you include the "management.css" file you'll be much closer, since it should make the buttons look somewhat like the ones on the main management page: But you'll probably still want to play around with it to make sure they have the same heights, etc. I'd also suggest reducing the space at the top of the template (looks like there are four line breaks for some reason?) |
|
fixed a teds changes and also make it look better by organizing the buttons yay @willgearty |
* Initial docs for stable release 13 * Docs for #3116, #3117, and #3118 * Added docs about django upgrade * Docs for #3128 * Docs for #3129, #3133, #3134, and #3137 * Docs for #3156 and #3153 * Docs for #3174, #3163, and #3184 * Docs for #3139, #3140, and #3141 * Docs for #3143, #3150, #3154, #3160, #3162, and #3168 * Docs for #3171, #3185, #3186, and #3188 * Docs for #3131 and #3189 * Docs for #3149 and #3190 * Docs for #3193, #3194, #3195, #196, and #3197 * Clarification * Docs for #3192, #3201, #3209, and #2248 * Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226 * Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239 * Fix indent * Docs for #3227 and #3235 * Add missing word * spelling * Docs for e57581f, #3255, #3253, #3257, and #3249 * Docs for #3254, #3260, and #3262 * Docs for #3263, #3272, #3240, #3264, #3266, and #3270 * clarifications * Docs for #3283 and #3252 * Docs for #3288 and misc commits * Docs for #3292, #3311, #3286, #3289, and #3279 * Docs for a377f0d; move note * Docs for #3315, #3290, and #3322 * Docs for #3273 and #3317 * Final edits
Makes onsite links into buttons - also introduces a class called makeButtonLink which can be called to make a link that is a button.
Should be useful if anyone is making a new page and wants to make a link, that is you know, a button.
If anyone has any comments on how I could make the onsite page prettyier that would be great.