double quote name when part of the email address #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that names with special characters like commas and periods are processed correctly. Also, change all the places where we manually build email recipients to use ESPUser.email_sendto_address
This comment has been minimized.
This comment has been minimized.
willgearty
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
I double checked all of the changes and it all checks out, including the order of the arguments. Therefore, I'm approving this, but I'll also add that we could probably use the get_email_sendto_address() method to clean up the code in several places where we're working with an actual ESPUser object (we'll need to keep using the static method where we are using the director_email or something similar). It's up to you @hwatheod.
|
@willgearty Good call on using |
This comment has been minimized.
This comment has been minimized.
willgearty
reviewed
Apr 13, 2021
Co-authored-by: Will Gearty <willgearty@gmail.com>
|
This pull request fixes 1 alert when merging 6a71133 into 128e805 - view on LGTM.com fixed alerts:
|
willgearty
approved these changes
Apr 13, 2021
willgearty
added a commit
that referenced
this pull request
May 27, 2021
* Initial docs for stable release 13 * Docs for #3116, #3117, and #3118 * Added docs about django upgrade * Docs for #3128 * Docs for #3129, #3133, #3134, and #3137 * Docs for #3156 and #3153 * Docs for #3174, #3163, and #3184 * Docs for #3139, #3140, and #3141 * Docs for #3143, #3150, #3154, #3160, #3162, and #3168 * Docs for #3171, #3185, #3186, and #3188 * Docs for #3131 and #3189 * Docs for #3149 and #3190 * Docs for #3193, #3194, #3195, #196, and #3197 * Clarification * Docs for #3192, #3201, #3209, and #2248 * Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226 * Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239 * Fix indent * Docs for #3227 and #3235 * Add missing word * spelling * Docs for e57581f, #3255, #3253, #3257, and #3249 * Docs for #3254, #3260, and #3262 * Docs for #3263, #3272, #3240, #3264, #3266, and #3270 * clarifications * Docs for #3283 and #3252 * Docs for #3288 and misc commits * Docs for #3292, #3311, #3286, #3289, and #3279 * Docs for a377f0d; move note * Docs for #3315, #3290, and #3322 * Docs for #3273 and #3317 * Final edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3230 by ensuring that names with special characters like commas and periods are processed correctly. The ESPUser.email_sendto_address now encloses the name in double quotes, and escapes existing double quotes with a backslash.
Also, change all the places where we manually build email recipients to use the ESPUser.email_sendto_address function instead.
NOTE TO REVIEWERS: Please double check that my changes from the old code to the ESPUser.email_sendto_address function are correct. Particularly note that the order of parameters for ESPUser.email_sendto_address is email first then name, whereas the original code was in the opposite order.
These changes will probably be easier to review if you view the diff in "Unified" mode.