Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher barcode check-in #3240

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Teacher barcode check-in #3240

merged 8 commits into from
Apr 30, 2021

Conversation

willgearty
Copy link
Member

This adds barcodes to teacher schedules (and makes them a bit prettier) and then adds the ability to scan those barcodes with physical scanners or the user's device on the teacher check-in page. I also made the teacher check-in page a little friendlier for teachers that might be teaching multiple classes at once (since the ajax scheduler now allows this via the override).

@milescalabresi has physical scanners, so he could test the functionality for that.

And also, as @kkbrum mentioned during development, this will likely be a major component of the admin webapp, but this PR will need to suffice until then.

Fixes #2847.

@lgtm-com

This comment has been minimized.

@willgearty
Copy link
Member Author

OK, that should fix the LGTM problems that we actually need to worry about.

@lgtm-com

This comment has been minimized.

@kkbrum
Copy link
Contributor

kkbrum commented Mar 18, 2021

Okay so using the teacher schedules, although I only have 4 data points, the single digit user IDs scan whereas the double digit user IDs don't (perhaps this is correlation and not causation though). Using the teacher nametags with barcodes on the back, they all scan. Looking at the difference between the barcodes on the schedules vs the nametags, the only difference I see is that the bars on the nametags are thicker?

For user ID 4, username "tteacher@" (for the sake of testing weird characters), I get the following console error when scanning:
image

@willgearty
Copy link
Member Author

OK, I've tested the new code with barcodes up to 4 digits and they work fine now. It should also now handle weird usernames.

@lgtm-com

This comment has been minimized.

Copy link
Contributor

@kkbrum kkbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless!

@willgearty willgearty merged commit ccff37a into main Apr 30, 2021
@willgearty willgearty deleted the teach-barcode branch April 30, 2021 00:28
willgearty added a commit that referenced this pull request May 1, 2021
@willgearty willgearty linked an issue May 26, 2021 that may be closed by this pull request
willgearty added a commit that referenced this pull request May 27, 2021
* Initial docs for stable release 13

* Docs for #3116, #3117, and #3118

* Added docs about django upgrade

* Docs for #3128

* Docs for #3129, #3133, #3134, and #3137

* Docs for #3156 and #3153

* Docs for #3174, #3163, and #3184

* Docs for #3139, #3140, and #3141

* Docs for #3143, #3150, #3154, #3160, #3162, and #3168

* Docs for #3171, #3185, #3186, and #3188

* Docs for #3131 and #3189

* Docs for #3149 and #3190

* Docs for #3193, #3194, #3195, #196, and #3197

* Clarification

* Docs for #3192, #3201, #3209, and #2248

* Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226

* Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239

* Fix indent

* Docs for #3227 and #3235

* Add missing word

* spelling

* Docs for e57581f, #3255, #3253, #3257, and #3249

* Docs for #3254, #3260, and #3262

* Docs for #3263, #3272, #3240, #3264, #3266, and #3270

* clarifications

* Docs for #3283 and #3252

* Docs for #3288 and misc commits

* Docs for #3292, #3311, #3286, #3289, and #3279

* Docs for a377f0d; move note

* Docs for #3315, #3290, and #3322

* Docs for #3273 and #3317

* Final edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barcode checkin for teachers Non-unique CSS ids on /missingteachers
2 participants