Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery to 1.12.4, use cdnjs #2248

Merged
merged 14 commits into from
Feb 18, 2021
Merged

Update jQuery to 1.12.4, use cdnjs #2248

merged 14 commits into from
Feb 18, 2021

Conversation

betaveros
Copy link
Member

Closes #2221.

@benjaminjkraft
Copy link
Contributor

Hmm, have you checked jquery changelogs to see what breaking changes we might need to worry about? In the past we've often had to make several changes to upgrade jquery.

@willgearty
Copy link
Member

@betaveros Have you had a chance to follow up on this to check what breaking changes we might need to address? Our jQuery is horrendously out-of-date, and it would be great to upgrade.

@willgearty willgearty requested review from kkbrum and removed request for kkbrum February 15, 2021 15:45
@willgearty
Copy link
Member

OK, I went ahead and finished this PR up. Here are the additional changes I made:

  1. Added our jquery version to the settings so we only need to change the number in a single place next time.
  2. Same with jquery-ui (but that hasn't been updated since 2016, so I'm not expecting a new release any time soon).
  3. Both are now always pulled from a remote CDN (not ours) and use the same version for every page (one exception, see grid-based class changes uses old jquery-ui #3210).
  4. I used the migrate tool here to find any deprecated javascript in our codebase. I fixed any that I could find, and I left the tool migrate tool in so it will catch any remaining errors (until we want to upgrade to jquery 2 or 3). On dev servers, it will spit out a console warning if there are any problems. On the production server it will just quietly fix our code for us.
  5. I updated our local version of jquery-grid (mostly used for the custom form responses page, I believe).
  6. On two pages, we weren't importing common.js, which converts our version of jquery from "$" to "$j", so I fixed that.
  7. A couple random fixes I ran into while testing various pages.

Copy link
Contributor

@kkbrum kkbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to look through all the javascript heavy pages, particularly those with edits, and nothing looks broken to me! I did not look at the admissions dashboard since I've never really seen it in the past, but everything else looks good to me.

@willgearty willgearty merged commit 7bfdf76 into main Feb 18, 2021
@willgearty willgearty deleted the update-jquery branch February 18, 2021 15:53
willgearty added a commit that referenced this pull request Feb 18, 2021
willgearty added a commit that referenced this pull request May 27, 2021
* Initial docs for stable release 13

* Docs for #3116, #3117, and #3118

* Added docs about django upgrade

* Docs for #3128

* Docs for #3129, #3133, #3134, and #3137

* Docs for #3156 and #3153

* Docs for #3174, #3163, and #3184

* Docs for #3139, #3140, and #3141

* Docs for #3143, #3150, #3154, #3160, #3162, and #3168

* Docs for #3171, #3185, #3186, and #3188

* Docs for #3131 and #3189

* Docs for #3149 and #3190

* Docs for #3193, #3194, #3195, #196, and #3197

* Clarification

* Docs for #3192, #3201, #3209, and #2248

* Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226

* Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239

* Fix indent

* Docs for #3227 and #3235

* Add missing word

* spelling

* Docs for e57581f, #3255, #3253, #3257, and #3249

* Docs for #3254, #3260, and #3262

* Docs for #3263, #3272, #3240, #3264, #3266, and #3270

* clarifications

* Docs for #3283 and #3252

* Docs for #3288 and misc commits

* Docs for #3292, #3311, #3286, #3289, and #3279

* Docs for a377f0d; move note

* Docs for #3315, #3290, and #3322

* Docs for #3273 and #3317

* Final edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Javascript UserInterface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jQuery version is old
4 participants