Give all contact infos a user #3131
Conversation
| if not (ci.first_name and ci.last_name): | ||
| # We want to delete emergency contact info for non-students |
There was a problem hiding this comment.
Don't see the relationship between the code and the comment. How is having (or not having) a first name and last name the same as being (or not being) a student?
There was a problem hiding this comment.
Ah, so I'm trying to retroactively fix the problem caused by this old line (now moved into the student forloop):
ESP-Website/esp/esp/web/views/myesp.py
Line 174 in 0fa4528
We used to add a
contact_emergency for all users, not just students. But we only ask for emergency contact info in the student version of the profile form, so it always resulted in a blank contactinfo. So here we are looking to see if a contact info has been used for contact_emergency but does not have a first and last name (indicating it was created by the above line for a non-student).
| # Only get contact infos that are for the actual users (not guardians or emergency contacts) | ||
| states_raw = ContactInfo.objects.filter(user__in=users, as_user__isnull=False |
There was a problem hiding this comment.
I don't quite understand this as_user condition. How does it tell us that the ContactInfo is for the actual user? I thought as_user was related to registration profiles.
There was a problem hiding this comment.
as_user is the set of registration profiles that use the contact info as the contact_user relationship. Otherwise, they use them for contact_emergency or contact_guardian relationship (if the user is a student). If we find that the contact info has been used as the contact_user relationship (as_user__isnull=False), then we know this is the contact info for the actual user.
|
I searched GitHub for all the uses of either |
There was a problem hiding this comment.
The migration worked well for me, cleaning up the contact infos without removing anything extra and assigning users as I would have expected it to. I tested creating a student account and the contact infos for the student, parent, and emergency contact all looked good with the affiliated user (and the user search allowed searching by parent & emergency contact info). I also tested that creating a teacher account only creates one contact info for the teacher. If there's anything else I should test, let me know, but otherwise this looks great!
* Initial docs for stable release 13 * Docs for #3116, #3117, and #3118 * Added docs about django upgrade * Docs for #3128 * Docs for #3129, #3133, #3134, and #3137 * Docs for #3156 and #3153 * Docs for #3174, #3163, and #3184 * Docs for #3139, #3140, and #3141 * Docs for #3143, #3150, #3154, #3160, #3162, and #3168 * Docs for #3171, #3185, #3186, and #3188 * Docs for #3131 and #3189 * Docs for #3149 and #3190 * Docs for #3193, #3194, #3195, #196, and #3197 * Clarification * Docs for #3192, #3201, #3209, and #2248 * Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226 * Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239 * Fix indent * Docs for #3227 and #3235 * Add missing word * spelling * Docs for e57581f, #3255, #3253, #3257, and #3249 * Docs for #3254, #3260, and #3262 * Docs for #3263, #3272, #3240, #3264, #3266, and #3270 * clarifications * Docs for #3283 and #3252 * Docs for #3288 and misc commits * Docs for #3292, #3311, #3286, #3289, and #3279 * Docs for a377f0d; move note * Docs for #3315, #3290, and #3322 * Docs for #3273 and #3317 * Final edits
I've made the following changes:
ContactInfo.addOrUpdatenow require a user object.userfield required for ContactInfos (including a migration).In addition to the benefits of all ContactInfos now having an associated user and deleting a bunch of unneeded/blank ContactInfos, this also makes it possible to perform a user search based on any information within emergency contact or guardian ContactInfos (e.g. find a student from their parent's email address), which has been requested many many times by chapters.
I've tested the migrations multiple times, but it would be good to get another set of eyes on them and their application to make sure no important data is accidentally deleted.
Fixes #1075 and fixes #1903.