Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centers Bigpicture #3254

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Centers Bigpicture #3254

merged 3 commits into from
Apr 23, 2021

Conversation

nrjean
Copy link
Contributor

@nrjean nrjean commented Apr 9, 2021

Does what is say - redefines the width of the container to 1180 pixels which centers the content area of big picture.
Fixes #3020

Copy link
Member

@willgearty willgearty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a different width is defined in theme_compiled.css. I'd suggest changing the less file that defines the bigpicture width for the container class instead of hard coding it into the template here.

@willgearty
Copy link
Member

Yep, looks good on my dev server (and on Cloud), just need the change requested above.

@nrjean
Copy link
Contributor Author

nrjean commented Apr 23, 2021

all done

@willgearty willgearty merged commit b3309c4 into main Apr 23, 2021
@willgearty willgearty deleted the center_bigpicture branch April 23, 2021 01:02
willgearty added a commit that referenced this pull request Apr 26, 2021
willgearty added a commit that referenced this pull request May 27, 2021
* Initial docs for stable release 13

* Docs for #3116, #3117, and #3118

* Added docs about django upgrade

* Docs for #3128

* Docs for #3129, #3133, #3134, and #3137

* Docs for #3156 and #3153

* Docs for #3174, #3163, and #3184

* Docs for #3139, #3140, and #3141

* Docs for #3143, #3150, #3154, #3160, #3162, and #3168

* Docs for #3171, #3185, #3186, and #3188

* Docs for #3131 and #3189

* Docs for #3149 and #3190

* Docs for #3193, #3194, #3195, #196, and #3197

* Clarification

* Docs for #3192, #3201, #3209, and #2248

* Docs for #3204, #3212, #3214, #3205, 9fd073c, and #3226

* Docs for #3232, de5861c, #3231, #3233, #3234, #3237, #3238, and #3239

* Fix indent

* Docs for #3227 and #3235

* Add missing word

* spelling

* Docs for e57581f, #3255, #3253, #3257, and #3249

* Docs for #3254, #3260, and #3262

* Docs for #3263, #3272, #3240, #3264, #3266, and #3270

* clarifications

* Docs for #3283 and #3252

* Docs for #3288 and misc commits

* Docs for #3292, #3311, #3286, #3289, and #3279

* Docs for a377f0d; move note

* Docs for #3315, #3290, and #3322

* Docs for #3273 and #3317

* Final edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigpicture theme content isn't centered
2 participants