Add Plugin Labels and Prepackaged Plugin Info by aaronrothschild · Pull Request #3395 · mattermost/docs

aaronrothschild · 2020-02-14T19:55:22Z

~~Added Section for Plugin Labels describing them~~
pre-packaged plugins can now be removed from the system console
pre-packaged plugins are automatically installed only if enabled: this means some plugins might "disappear" on upgrade
pre-packaged plugins can be installed from the marketplace, even when offline

aaronrothschild · 2020-02-14T20:54:21Z

Incorporated @lieut-data 's suggestions. Going to publish Labels text later.

amyblais · 2020-02-14T22:02:39Z

Merging v5.20 docs into master.

amyblais · 2020-02-14T23:52:51Z

@aaronrothschild I had to change the branch to master because I needed to merge v5.20 docs into master. It seems some extra commits got added to this PR because of it. Sorry about that. I can help re-submit this PR if you don't have time.

lieut-data

Removing from my review plate until rebase completed.

aaronrothschild · 2020-02-28T15:14:47Z

@amyblais I'm not really sure what to do to get those commits out and don't want to screw anything up ;) . What do I need to do?

amyblais · 2020-02-28T15:26:44Z

You can re-submit the PR @aaronrothschild

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

lieut-data · 2020-02-28T15:43:11Z

@aaronrothschild / @amyblais, I've rebased this on top of master to eliminate the duplicate commits. Let me know if that looks good!

amyblais · 2020-02-28T15:44:19Z

Looks good.

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

lieut-data

A few suggestions below -- thanks @aaronrothschild!

Co-Authored-By: Jesse Hallam <jesse.hallam@gmail.com>

Stylistic changes: Updated headings in line with new style guide, and fixed erroneous prepackaged to pre-packaged.

@hanzei

Dismissing my own review in favour of getting @hanzei's eyes on this.

hanzei

LGMT 👍

* master: Add Plugin Labels and Prepackaged Plugin Info (#3395) Adding NPS rating for docs pages (#3469) Fix broken link in Bot Account Creation > Plugin (#3493) # Conflicts: # source/myscript.js

…/docs into justinegeffen-patch-7 * 'justinegeffen-patch-7' of https://github.com/mattermost/docs: (90 commits) Update integrations.rst Remove Oracle from Bitnami packages (#3491) Revert "Adding NPS rating for docs pages (#3469)" (#3495) Add Plugin Labels and Prepackaged Plugin Info (#3395) Adding NPS rating for docs pages (#3469) Fix broken link in Bot Account Creation > Plugin (#3493) Added Let's Encrypt clarification (#2866) Update security.rst (#3434) Update sg_grammar-spelling-mechanics.rst (#3462) Update training.rst (#3485) Update release-faq.rst (#3484) Documenting how to change the default docker-compose network (#3480) Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482) Correct Code Block Formatting (#3477) Update mmctl-cli-tool.rst (#3481) FAQ on Archived Channels and data retention (#3470) Update desktop-changelog.rst (#3473) Update desktop-changelog.rst (#3471) Added Video to AD/LDAP Group Sync (#3450) Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427) ... # Conflicts: # source/install/troubleshooting.rst

aaronrothschild added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Feb 14, 2020

aaronrothschild requested review from alifarooq0, amyblais and lieut-data February 14, 2020 19:55

aaronrothschild self-assigned this Feb 14, 2020

aaronrothschild added this to the v5.20 milestone Feb 14, 2020

amyblais reviewed Feb 14, 2020

View reviewed changes

Comment thread source/administration/plugins.rst Outdated

amyblais reviewed Feb 14, 2020

View reviewed changes

Comment thread source/administration/plugins.rst Outdated

lieut-data requested changes Feb 14, 2020

View reviewed changes

aaronrothschild requested a review from lieut-data February 14, 2020 20:54

amyblais added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Feb 14, 2020

amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Feb 14, 2020

amyblais changed the base branch from v5.20-documentation to master February 14, 2020 22:12

amyblais added the Awaiting Submitter Action Blocked on the author label Feb 17, 2020

lieut-data requested changes Feb 26, 2020

View reviewed changes

aaronrothschild and others added 3 commits February 28, 2020 11:42

updated pre-packaged plugin info

35aeb5a

punctuation

113f742

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

Incorporated suggestions

ca836c2

lieut-data force-pushed the aaronrothschild-patch-2 branch from 81cc902 to ca836c2 Compare February 28, 2020 15:42

amyblais requested review from amyblais and lieut-data February 28, 2020 15:44

amyblais removed the Awaiting Submitter Action Blocked on the author label Feb 28, 2020

amyblais reviewed Feb 28, 2020

View reviewed changes

Comment thread source/administration/plugins.rst Outdated

Update source/administration/plugins.rst

513bdde

Co-Authored-By: Amy Blais <amy_blais@hotmail.com>

lieut-data previously requested changes Mar 2, 2020

View reviewed changes

Comment thread source/administration/plugins.rst Outdated

Comment thread source/administration/plugins.rst Outdated

Comment thread source/administration/plugins.rst Outdated

justinegeffen and others added 4 commits April 6, 2020 14:32

Update source/administration/plugins.rst

4e07730

Co-Authored-By: Jesse Hallam <jesse.hallam@gmail.com>

Update source/administration/plugins.rst

66a1a91

Co-Authored-By: Jesse Hallam <jesse.hallam@gmail.com>

Update source/administration/plugins.rst

1bb1892

Co-Authored-By: Jesse Hallam <jesse.hallam@gmail.com>

Update plugins.rst

72a4da1

Stylistic changes: Updated headings in line with new style guide, and fixed erroneous prepackaged to pre-packaged.

lieut-data requested a review from hanzei April 6, 2020 12:44

lieut-data removed the request for review from alifarooq0 April 6, 2020 12:44

hanzei approved these changes Apr 6, 2020

View reviewed changes

hanzei requested a review from amyblais April 6, 2020 15:27

hanzei added 2: Editor Review Requires review by an editor and removed 1: Dev Review Requires review by a core commiter labels Apr 6, 2020

amyblais reviewed Apr 6, 2020

View reviewed changes

Comment thread source/administration/plugins.rst Outdated

Update source/administration/plugins.rst

f9290bc

amyblais approved these changes Apr 6, 2020

View reviewed changes

amyblais added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Apr 6, 2020

amyblais merged commit 3fbc001 into master Apr 6, 2020

amyblais deleted the aaronrothschild-patch-2 branch April 6, 2020 16:11

amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Apr 13, 2020

hanzei unassigned aaronrothschild Apr 22, 2020

hanzei mentioned this pull request Apr 22, 2020

Document plugin labels #3548

Merged

Conversation

aaronrothschild commented Feb 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aaronrothschild commented Feb 14, 2020

Uh oh!

amyblais commented Feb 14, 2020

Uh oh!

amyblais commented Feb 14, 2020

Uh oh!

lieut-data left a comment

Choose a reason for hiding this comment

Uh oh!

aaronrothschild commented Feb 28, 2020

Uh oh!

amyblais commented Feb 28, 2020

Uh oh!

lieut-data commented Feb 28, 2020

Uh oh!

amyblais commented Feb 28, 2020

Uh oh!

Uh oh!

lieut-data left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanzei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aaronrothschild commented Feb 14, 2020 •

edited

Loading