Added Video to AD/LDAP Group Sync#3450
Merged
justinegeffen merged 2 commits intomasterfrom Mar 23, 2020
Merged
Conversation
…AD/LDAP video to ad/ldap group sync
jasonblais
approved these changes
Mar 14, 2020
Contributor
jasonblais
left a comment
jasonblais
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me.
@DSchalla heads up that your approval was requested to confirm if including an iframe in our docs is a security concern.
Also requesting @justinegeffen's help with editor review.
jasonblais
added
2: Editor Review
Reviewed addition of YouTube link; general review and some formatting fixes (unrelated to PR).
justinegeffen
approved these changes
Mar 15, 2020
Contributor
justinegeffen
left a comment
justinegeffen
left a comment
There was a problem hiding this comment.
I picked up some other minor fixes during this review. Really like the addition of the YouTube link! :)
Member
|
@jasonblais @faase Thanks for the context and sorry for the delayed review! Static iframes to a trusted URL are absolutely fine. |
DSchalla
approved these changes
Mar 23, 2020
justinegeffen
added
3: Reviews Complete
amyblais
removed
the
3: Reviews Complete
justinegeffen
pushed a commit
that referenced
this pull request
Apr 6, 2020
* master: Added Let's Encrypt clarification (#2866) Update security.rst (#3434) Update sg_grammar-spelling-mechanics.rst (#3462) Update training.rst (#3485) Update release-faq.rst (#3484) Documenting how to change the default docker-compose network (#3480) Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482) Correct Code Block Formatting (#3477) Update mmctl-cli-tool.rst (#3481) FAQ on Archived Channels and data retention (#3470) Update desktop-changelog.rst (#3473) Update desktop-changelog.rst (#3471) Added Video to AD/LDAP Group Sync (#3450) Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427) Update bug-severity-guidelines.rst (#3467) Moving Push Proxy related entry to developer documentation (#3448)
justinegeffen
pushed a commit
that referenced
this pull request
Apr 8, 2020
…/docs into justinegeffen-patch-7 * 'justinegeffen-patch-7' of https://github.com/mattermost/docs: (90 commits) Update integrations.rst Remove Oracle from Bitnami packages (#3491) Revert "Adding NPS rating for docs pages (#3469)" (#3495) Add Plugin Labels and Prepackaged Plugin Info (#3395) Adding NPS rating for docs pages (#3469) Fix broken link in Bot Account Creation > Plugin (#3493) Added Let's Encrypt clarification (#2866) Update security.rst (#3434) Update sg_grammar-spelling-mechanics.rst (#3462) Update training.rst (#3485) Update release-faq.rst (#3484) Documenting how to change the default docker-compose network (#3480) Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482) Correct Code Block Formatting (#3477) Update mmctl-cli-tool.rst (#3481) FAQ on Archived Channels and data retention (#3470) Update desktop-changelog.rst (#3473) Update desktop-changelog.rst (#3471) Added Video to AD/LDAP Group Sync (#3450) Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427) ... # Conflicts: # source/install/troubleshooting.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add this video to the AD/LDAP Group Sync doc.
Ticket Link
No ticket # as this was an internal request.