Skip to content

Hint to "skip_slack_parsing" to ignore Slack-compatibility logic#3427

Merged
jasonblais merged 4 commits intomattermost:masterfrom
someone-somenet-org:patch-1
Mar 22, 2020
Merged

Hint to "skip_slack_parsing" to ignore Slack-compatibility logic#3427
jasonblais merged 4 commits intomattermost:masterfrom
someone-somenet-org:patch-1

Conversation

@someone-somenet-org
Copy link
Copy Markdown
Contributor

@someone-somenet-org someone-somenet-org commented Mar 3, 2020

Summary

Docs related to mattermost/mattermost#13976 change.

Ticket Link

mattermost/mattermost#13968
MM-22825

@lieut-data lieut-data requested review from iomodo and mickmister March 3, 2020 21:27
@lieut-data lieut-data added the 1: Dev Review Requires review by a core commiter label Mar 3, 2020
Copy link
Copy Markdown
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @someone-somenet-org, looks good to me! One minor change below :)

Comment thread source/developer/interactive-messages.rst Outdated
Co-Authored-By: Shota Gvinepadze <wineson@gmail.com>
@mickmister mickmister added the 1: PM Review Requires review by a product manager label Mar 6, 2020
Copy link
Copy Markdown
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one request on syntax. Thanks @someone-somenet-org!

Comment thread source/developer/interactive-messages.rst Outdated
Co-Authored-By: Michael Kochell <mjkochell@gmail.com>
@iomodo iomodo self-requested a review March 6, 2020 19:23
Copy link
Copy Markdown
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @someone-somenet-org ! Thanks a lot!

@iomodo iomodo requested a review from mickmister March 6, 2020 19:24
Copy link
Copy Markdown
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mickmister mickmister removed the 1: Dev Review Requires review by a core commiter label Mar 11, 2020
@mattermod
Copy link
Copy Markdown
Contributor

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

@jasonblais jasonblais added 3: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager Lifecycle/1:stale labels Mar 22, 2020
@jasonblais jasonblais merged commit 760f7c6 into mattermost:master Mar 22, 2020
@amyblais amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Mar 23, 2020
@hanzei hanzei added the 3: Reviews Complete All reviewers have approved the pull request label Mar 23, 2020
@amyblais amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Mar 27, 2020
justinegeffen pushed a commit that referenced this pull request Apr 6, 2020
* master:
  Added Let's Encrypt clarification  (#2866)
  Update security.rst (#3434)
  Update sg_grammar-spelling-mechanics.rst (#3462)
  Update training.rst (#3485)
  Update release-faq.rst (#3484)
  Documenting how to change the default docker-compose network (#3480)
  Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482)
  Correct Code Block Formatting (#3477)
  Update mmctl-cli-tool.rst (#3481)
  FAQ on Archived Channels and data retention (#3470)
  Update desktop-changelog.rst (#3473)
  Update desktop-changelog.rst (#3471)
  Added Video to AD/LDAP Group Sync (#3450)
  Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427)
  Update bug-severity-guidelines.rst (#3467)
  Moving Push Proxy related entry to developer documentation (#3448)
justinegeffen pushed a commit that referenced this pull request Apr 8, 2020
…/docs into justinegeffen-patch-7

* 'justinegeffen-patch-7' of https://github.com/mattermost/docs: (90 commits)
  Update integrations.rst
  Remove Oracle from Bitnami packages (#3491)
  Revert "Adding NPS rating for docs pages (#3469)" (#3495)
  Add Plugin Labels and Prepackaged Plugin Info (#3395)
  Adding NPS rating for docs pages (#3469)
  Fix broken link in Bot Account Creation > Plugin (#3493)
  Added Let's Encrypt clarification  (#2866)
  Update security.rst (#3434)
  Update sg_grammar-spelling-mechanics.rst (#3462)
  Update training.rst (#3485)
  Update release-faq.rst (#3484)
  Documenting how to change the default docker-compose network (#3480)
  Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482)
  Correct Code Block Formatting (#3477)
  Update mmctl-cli-tool.rst (#3481)
  FAQ on Archived Channels and data retention (#3470)
  Update desktop-changelog.rst (#3473)
  Update desktop-changelog.rst (#3471)
  Added Video to AD/LDAP Group Sync (#3450)
  Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427)
  ...

# Conflicts:
#	source/install/troubleshooting.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants