Added Let's Encrypt clarification #2866
Merged
crspeller merged 7 commits intomattermost:masterfrom Apr 1, 2020
Merged
Conversation
… your server to verify the domain Signed-off-by: Paul Rothrock <paul@movetoiceland.com>
amyblais
reviewed
Jul 24, 2019
Contributor
|
@crspeller can you help with a dev review, and then we can get this merged (after the one typo fix noted by Amy above) |
crspeller
requested changes
Jul 29, 2019
Contributor
|
Thanks! @icelander FYI on two small suggestions above, looks like I don't have push access to your branch to make them myself, |
Contributor
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
Contributor
|
Friendly reminder to help with the above two suggestions @icelander when you have a moment :) Otherwise looks like this is ready to merge |
Contributor
|
Following up on this - @icelander, if you have a moment to address the two changes then it looks like we should be good to go. |
Co-Authored-By: Amy Blais <amy_blais@hotmail.com>
Contributor
|
Hi @icelander. I've committed the suggested changes as they were related to formatting. Re-requesting reviews so we can move the PR forward. |
amyblais
reviewed
Apr 1, 2020
amyblais
approved these changes
Apr 1, 2020
amyblais
removed
2: Editor Review
crspeller
approved these changes
Apr 1, 2020
crspeller
removed
1: Dev Review
Member
|
/update-branch |
amyblais
removed
the
3: Reviews Complete
justinegeffen
pushed a commit
that referenced
this pull request
Apr 6, 2020
* master: Added Let's Encrypt clarification (#2866) Update security.rst (#3434) Update sg_grammar-spelling-mechanics.rst (#3462) Update training.rst (#3485) Update release-faq.rst (#3484) Documenting how to change the default docker-compose network (#3480) Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482) Correct Code Block Formatting (#3477) Update mmctl-cli-tool.rst (#3481) FAQ on Archived Channels and data retention (#3470) Update desktop-changelog.rst (#3473) Update desktop-changelog.rst (#3471) Added Video to AD/LDAP Group Sync (#3450) Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427) Update bug-severity-guidelines.rst (#3467) Moving Push Proxy related entry to developer documentation (#3448)
justinegeffen
pushed a commit
that referenced
this pull request
Apr 8, 2020
…/docs into justinegeffen-patch-7 * 'justinegeffen-patch-7' of https://github.com/mattermost/docs: (90 commits) Update integrations.rst Remove Oracle from Bitnami packages (#3491) Revert "Adding NPS rating for docs pages (#3469)" (#3495) Add Plugin Labels and Prepackaged Plugin Info (#3395) Adding NPS rating for docs pages (#3469) Fix broken link in Bot Account Creation > Plugin (#3493) Added Let's Encrypt clarification (#2866) Update security.rst (#3434) Update sg_grammar-spelling-mechanics.rst (#3462) Update training.rst (#3485) Update release-faq.rst (#3484) Documenting how to change the default docker-compose network (#3480) Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482) Correct Code Block Formatting (#3477) Update mmctl-cli-tool.rst (#3481) FAQ on Archived Channels and data retention (#3470) Update desktop-changelog.rst (#3473) Update desktop-changelog.rst (#3471) Added Video to AD/LDAP Group Sync (#3450) Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427) ... # Conflicts: # source/install/troubleshooting.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added clarification that Let's Encrypt needs to be able to connect to your server to verify the domain
Signed-off-by: Paul Rothrock paul@movetoiceland.com