Skip to content

Update security.rst#3434

Merged
wiersgallak merged 7 commits intomasterfrom
justinegeffen-patch-6-1
Mar 31, 2020
Merged

Update security.rst#3434
wiersgallak merged 7 commits intomasterfrom
justinegeffen-patch-6-1

Conversation

@justinegeffen
Copy link
Copy Markdown
Contributor

@justinegeffen justinegeffen commented Mar 5, 2020

Minor punctuation and terminology fixes. Updated security policies section based on: #885.

@justinegeffen
Update security.rst
1094dea 
Punctuation and terminology fixes. Added new content to security policies section based on: #885
@justinegeffen justinegeffen added 1: Dev Review Requires review by a core commiter 1: PM Review Requires review by a product manager 2: Editor Review Requires review by an editor labels Mar 5, 2020
@justinegeffen justinegeffen linked an issue Mar 5, 2020 that may be closed by this pull request
Document design decision behind email/password enumeration during authentication #885
Closed
lieut-data
lieut-data requested changes Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! A few comments re: the meat of the security discussion.

Comment thread source/overview/security.rst Outdated
Comment thread source/overview/security.rst Outdated
justinegeffen
justinegeffen commented Mar 5, 2020
View reviewed changes
Comment thread source/overview/security.rst Outdated
justinegeffen
justinegeffen commented Mar 5, 2020
View reviewed changes
Comment thread source/overview/security.rst Outdated
@justinegeffen
Copy link
Copy Markdown
Contributor Author

justinegeffen commented Mar 5, 2020

Thanks for the feedback, @lieut-data - much appreciated. Changes have been made and committed. :)

lieut-data
lieut-data approved these changes Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @justinegeffen! One inline follow up just for discussion, but not blocking on my end now. 🎉

Comment thread source/overview/security.rst Outdated
amyblais
amyblais reviewed Mar 5, 2020
View reviewed changes
Comment thread source/overview/security.rst Outdated
amyblais
amyblais reviewed Mar 5, 2020
View reviewed changes
Comment thread source/overview/security.rst Outdated
@justinegeffen @amyblais
Update source/overview/security.rst
95883a2 
Co-Authored-By: Amy Blais <amy_blais@hotmail.com>
justinegeffen
justinegeffen commented Mar 5, 2020
View reviewed changes
Comment thread source/overview/security.rst Outdated
wiersgallak
wiersgallak reviewed Mar 6, 2020
View reviewed changes
Comment thread source/overview/security.rst Outdated
@justinegeffen justinegeffen removed the 1: Dev Review Requires review by a core commiter label Mar 9, 2020
justinegeffen
justinegeffen commented Mar 9, 2020
View reviewed changes
Comment thread source/overview/security.rst Outdated
@amyblais amyblais removed the 2: Editor Review Requires review by an editor label Mar 30, 2020
wiersgallak
wiersgallak approved these changes Mar 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Justine!

@wiersgallak wiersgallak added 3: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager labels Mar 31, 2020
@wiersgallak wiersgallak merged commit a2c8449 into master Mar 31, 2020
@wiersgallak wiersgallak deleted the justinegeffen-patch-6-1 branch March 31, 2020 15:05
@amyblais amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Apr 1, 2020
justinegeffen pushed a commit that referenced this pull request Apr 6, 2020
Merge branch 'master' into c-thermometer
4e68c77 
* master:
  Added Let's Encrypt clarification  (#2866)
  Update security.rst (#3434)
  Update sg_grammar-spelling-mechanics.rst (#3462)
  Update training.rst (#3485)
  Update release-faq.rst (#3484)
  Documenting how to change the default docker-compose network (#3480)
  Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482)
  Correct Code Block Formatting (#3477)
  Update mmctl-cli-tool.rst (#3481)
  FAQ on Archived Channels and data retention (#3470)
  Update desktop-changelog.rst (#3473)
  Update desktop-changelog.rst (#3471)
  Added Video to AD/LDAP Group Sync (#3450)
  Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427)
  Update bug-severity-guidelines.rst (#3467)
  Moving Push Proxy related entry to developer documentation (#3448)
justinegeffen pushed a commit that referenced this pull request Apr 8, 2020
Merge branch 'justinegeffen-patch-7' of https://github.com/mattermost…
ab11444 
…/docs into justinegeffen-patch-7

* 'justinegeffen-patch-7' of https://github.com/mattermost/docs: (90 commits)
  Update integrations.rst
  Remove Oracle from Bitnami packages (#3491)
  Revert "Adding NPS rating for docs pages (#3469)" (#3495)
  Add Plugin Labels and Prepackaged Plugin Info (#3395)
  Adding NPS rating for docs pages (#3469)
  Fix broken link in Bot Account Creation > Plugin (#3493)
  Added Let's Encrypt clarification  (#2866)
  Update security.rst (#3434)
  Update sg_grammar-spelling-mechanics.rst (#3462)
  Update training.rst (#3485)
  Update release-faq.rst (#3484)
  Documenting how to change the default docker-compose network (#3480)
  Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482)
  Correct Code Block Formatting (#3477)
  Update mmctl-cli-tool.rst (#3481)
  FAQ on Archived Channels and data retention (#3470)
  Update desktop-changelog.rst (#3473)
  Update desktop-changelog.rst (#3471)
  Added Video to AD/LDAP Group Sync (#3450)
  Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427)
  ...

# Conflicts:
#	source/install/troubleshooting.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lieut-data lieut-data lieut-data approved these changes

@amyblais amyblais amyblais approved these changes

@wiersgallak wiersgallak wiersgallak approved these changes

+1 more reviewer

@thefactremains thefactremains thefactremains approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document design decision behind email/password enumeration during authentication

5 participants

@justinegeffen @lieut-data @thefactremains @amyblais @wiersgallak