Skip to content

Moving Push Proxy related entry to developer documentation#3448

Merged
jasonblais merged 3 commits intomasterfrom
faase-faq-cleanup_001
Mar 20, 2020
Merged

Moving Push Proxy related entry to developer documentation#3448
jasonblais merged 3 commits intomasterfrom
faase-faq-cleanup_001

Conversation

@faase
Copy link
Copy Markdown
Contributor

@faase faase commented Mar 13, 2020

Summary

Moving the section How do I receive mobile push notification if my IT policy requires the use of a corporate proxy server? from the docs FAQ to https://developers.mattermost.com/contribute/mobile/push-notifications/service/ and removing the untested Deploy Mattermost in a proxy-aware configuration with a pre-proxy relay section completly

Ticket Link

This has no ticket # as it was an internal decision.

Copy link
Copy Markdown
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two proposals:

1 - Remove the definitions of pre-proxy and post-proxy relays as well given they were only referenced in this section and were found to be confusing https://docs.mattermost.com/overview/faq.html#what-are-pre-proxy-and-post-proxy-relays
2 - Instead of removing the FAQ entirely, propose leaving the question with an answer that redirects to the new page in dev docs site (submitted via mattermost/mattermost-developer-documentation#561). You can see an example of this here: https://docs.mattermost.com/overview/faq.html#what-happens-when-the-enterprise-edition-subscription-expires

(Reason I propose leaving the question with a redirect is that we've shared this FAQ with at least one customer previously -- thus removing the section entirely will let this customer in a dead end)

@faase
Copy link
Copy Markdown
Contributor Author

faase commented Mar 19, 2020

done ( I hope^^)

Copy link
Copy Markdown
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can merge once the dev docs PR is ready

@jasonblais jasonblais added 3: Reviews Complete All reviewers have approved the pull request Do Not Merge Should not be merged until this label is removed and removed 1: PM Review Requires review by a product manager Do Not Merge Should not be merged until this label is removed labels Mar 19, 2020
@jasonblais jasonblais merged commit d221fbf into master Mar 20, 2020
@jasonblais jasonblais deleted the faase-faq-cleanup_001 branch March 20, 2020 12:03
@amyblais amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Mar 20, 2020
justinegeffen pushed a commit that referenced this pull request Apr 6, 2020
* master:
  Added Let's Encrypt clarification  (#2866)
  Update security.rst (#3434)
  Update sg_grammar-spelling-mechanics.rst (#3462)
  Update training.rst (#3485)
  Update release-faq.rst (#3484)
  Documenting how to change the default docker-compose network (#3480)
  Fixes GH-542-Moved : Request for Documentation: Add to interactive-messages documentation (#3482)
  Correct Code Block Formatting (#3477)
  Update mmctl-cli-tool.rst (#3481)
  FAQ on Archived Channels and data retention (#3470)
  Update desktop-changelog.rst (#3473)
  Update desktop-changelog.rst (#3471)
  Added Video to AD/LDAP Group Sync (#3450)
  Hint to `"skip_slack_parsing"` to ignore Slack-compatibility logic (#3427)
  Update bug-severity-guidelines.rst (#3467)
  Moving Push Proxy related entry to developer documentation (#3448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants